Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing statements with multidimensional array #1656 #1657

Closed
wants to merge 2 commits into from

Conversation

lis412
Copy link

@lis412 lis412 commented Nov 2, 2022

fixes #1656

@lis412 lis412 changed the title Fix parsing statements with multidimensional array ##1656 Fix parsing statements with multidimensional array 1656 Nov 2, 2022
@lis412 lis412 changed the title Fix parsing statements with multidimensional array 1656 Fix parsing statements with multidimensional array #1656 Nov 2, 2022
@manticore-projects
Copy link
Contributor

Greetings!
Thank you for your contribution, it looks very good and clean! @wumpz Please approve.

Hint: you can add fixes #1656 to the description of the PR in order to link it. Then the issue will be closed automatically when the PR will be merged.

@wumpz
Copy link
Member

wumpz commented Nov 13, 2022

@manticore-projects Would approve, but your tests for keywords are failing. This method should be smoothed. Changing RegExp productions should be enough. BTW did you remove JavaCC dependency from JSqlParser?

@manticore-projects
Copy link
Contributor

manticore-projects commented Nov 13, 2022

Its not about the Test, the test is accurate.
LOCKED is not a reserved keyword but also has not been shown in RelObjectNameWithoutValue. Running the updateKeywords task is needed.

The problem here is only timing. The PR has been issued when you had the Tests deactivated and so got tested successfully. Now, when the Tests are active again, the PR fails.

mvn exec:java will solve it.

Alternatively, PR needs to be synched against Master.

@manticore-projects
Copy link
Contributor

Good news: the PR also helps regarding to

WARNING: UNRECORDED SUCCESS: for_update06.sql, please add to the EXPECTED_SUCCESSES List in SpecialOracleTest.java
Nov 14, 2022 5:45:59 AM net.sf.jsqlparser.statement.select.SpecialOracleTest recordSuccessOnSourceFile
WARNING: UNRECORDED SUCCESS: interval05.sql, please add to the EXPECTED_SUCCESSES List in SpecialOracleTest.java

@manticore-projects
Copy link
Contributor

manticore-projects commented Nov 13, 2022

I have tested it: The Keyword Tests worked exactly as expected and LOCKED needed to get white listed (running the updateKeywords task).

I have done that and also added the 2 additional Oracle Test, please pull from here: git@github.com:manticore-projects/JSqlParser.git

Alternatively, I have drafted another PR #1665 replacing this one. All Credits to @lis412 of course.

@wumpz wumpz closed this Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to parse statement with multidimensional array field
3 participants