Fixes #1684: Support CREATE MATERIALIZED VIEW with AUTO REFRESH #1691
Conversation
…RESH Support parsing create view statements in Redshift with AUTO REFRESH option.
|
please fix those branch conflicts first |
Done with Github UI so fingers crossed. |
|
You still have some PMD violations there. Look at the failing tests at GitHub. |
Extract adding the force option into a dedicated method resulting in the cyclomatic complexity reduction of the CreateView.toString method.
|
@wumpz can please help me understand how a failure in |
|
@zaza In the log file is written: This oracle test scans through a list of over 200 sqls. It expects 196 parse successes. Obviously your change somehow degraded the grammar so one sql could not be parsed anymore. |
|
Thanks @wumpz, but I got that part. I just don't understand how my change (in how CREATE VIEW is parsed/deparsed) could possibly broke the test. Like I said in my previous comment, the affected test file is |
| @@ -182,6 +182,11 @@ public static List<String> getReservedKeywords(int restriction) { | |||
|
|
|||
| , { "NEXTVAL", RESTRICTED_JSQLPARSER } | |||
|
|
|||
| , { "AUTO", RESTRICTED_JSQLPARSER } | |||
There was a problem hiding this comment.
Are those really restricted Keywords which must not been used?
Or are those just keywords? Why exactly have those Tokens been added?
- Merge PR JSQLParser#1691, fixes JSQLParser#1684 all credits go to @zaza
|
@zaza: I have merged your changes into PR #1722 and fixed it by remove the unnecessary In general, keywords must only be reserved, when absolutely needed to keep the parser working (and not in this case). Thank you for your contribution! Please consider to close this PR. |
|
Thanks @manticore-projects , closing the PR as requested. |
Support parsing create view statements in Redshift with AUTO REFRESH option.