Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for REFRESH MATERIALIZED VIEW #1911

Merged
merged 12 commits into from
Dec 11, 2023
Merged

feat: Add support for REFRESH MATERIALIZED VIEW #1911

merged 12 commits into from
Dec 11, 2023

Conversation

jxnu-liguobin
Copy link
Contributor

closed #1692

@jxnu-liguobin jxnu-liguobin marked this pull request as ready for review December 8, 2023 03:01
@manticore-projects
Copy link
Contributor

Greetings! Thank your for your contribution and welcome to the JSQLParser team.

@manticore-projects
Copy link
Contributor

manticore-projects commented Dec 9, 2023 •
edited
Loading

You added new Tokens and so you will need to update the Keywords as described here: https://manticore-projects.com/JSQLParser/contribution.html#manage-reserved-keywords

Also you will need to synchronize against latest commit since I amended the Grammar. Sorry for this hassle, there was no better way to incorporate needed corrections.

@jxnu-liguobin jxnu-liguobin force-pushed the support-materialized-view branch from 77c66eb to c5ba0f1 Compare December 11, 2023 01:13
@jxnu-liguobin jxnu-liguobin changed the title Support REFRESH MATERIALIZED VIEW feat: Add support for REFRESH MATERIALIZED VIEW Dec 11, 2023
@jxnu-liguobin
Copy link
Contributor Author

You added new Tokens and so you will need to update the Keywords as described here: https://manticore-projects.com/JSQLParser/contribution.html#manage-reserved-keywords

Also you will need to synchronize against latest commit since I amended the Grammar. Sorry for this hassle, there was no better way to incorporate needed corrections.

I modified the PR, how about it?

@manticore-projects manticore-projects merged commit 425c72e into JSQLParser:master Dec 11, 2023
3 of 5 checks passed
@manticore-projects
Copy link
Contributor

I modified the PR, how about it?

Kudos, very nicely done! Thank you for your contribution and look forward seeing more PRs from you soon.

@jxnu-liguobin
Copy link
Contributor Author

I modified the PR, how about it?

Kudos, very nicely done! Thank you for your contribution and look forward seeing more PRs from you soon.

Thank you, when is the next version expected to be released?

@manticore-projects
Copy link
Contributor

Thank you, when is the next version expected to be released?
@wumpz: I think we have the perfect material for a smooth End of Year Release, please consider a mvn publish as soon as you can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"REFRESH MATERIALIZED VIEW (...)" is not supported
2 participants
@jxnu-liguobin @manticore-projects