Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tables not find in parentheses join sql. #1956

Merged
merged 5 commits into from
Feb 7, 2024

Conversation

Hanchers
Copy link
Contributor

@Hanchers Hanchers commented Feb 6, 2024

to fix bug #1955

@manticore-projects
Copy link
Contributor

manticore-projects commented Feb 6, 2024

Thank you for your contribution and the fix, please see my comments.
The Spotless Formatter also raised concerns.

@Hanchers
Copy link
Contributor Author

Hanchers commented Feb 6, 2024

Thank you for your contribution and the fix, please see my comments. The Spotless Formatter also raised concerns.

fix and please review again

@manticore-projects
Copy link
Contributor

Thank you for your contribution and the fix, please see my comments. The Spotless Formatter also raised concerns.

fix and please review again

I still see the "star" imports, please import Classes explicitly instead.

@Hanchers
Copy link
Contributor Author

Hanchers commented Feb 7, 2024

Thank you for your contribution and the fix, please see my comments. The Spotless Formatter also raised concerns.

fix and please review again

I still see the "star" imports, please import Classes explicitly instead.

sorry, my idea have a auto import config that couse the "star" imports.
this time i fix this question and please review again.
thanks

@manticore-projects
Copy link
Contributor

Thank you for the corrections and your contribution. I am going to merge it.

@Hanchers
Copy link
Contributor Author

Hanchers commented Feb 7, 2024

Thank you for the corrections and your contribution. I am going to merge it.

thanks, my pleasure

@manticore-projects manticore-projects merged commit 182f484 into JSQLParser:master Feb 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants