-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new functions/methods to featurize module #330
base: main
Are you sure you want to change the base?
Conversation
Hi @JaGeo, there seems to be some issue with coverage artificats not being generated and uploaded in CI, I have not been able to pinpoint the cause yet. Will check again in detail tomorrow. Leaving this as a comment only for my reference here. |
Could be simply bug associated with a new release of pytest today. Will have to check downgrading it |
@naik-aakash sure. Don't worry! |
issue was with upload artificats update ignoring hidden files from being uploaded. It should be fixed now in PR #331 |
""" | ||
atom1 = element(atom_pair[0]) | ||
atom2 = element(atom_pair[1]) | ||
return (atom1.atomic_weight * atom2.atomic_weight) / (atom1.atomic_weight + atom2.atomic_weight) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think statistics here would also be interesting: min/max/mean etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean just the statistics for reduced masses of atom pairs, right? Or also atomic_weight-specific statistics?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of using the reduced mass, you could also order by min, mean, max in the bond
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I now inlcude the min, mean, max stats per bond type as per the suggestion
Closes #329
Changes