Skip to content

Commit

Permalink
Fix some typos (#8157)
Browse files Browse the repository at this point in the history
  • Loading branch information
koppor authored Oct 18, 2021
1 parent b844703 commit 71327b8
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 9 deletions.
2 changes: 1 addition & 1 deletion src/main/java/org/jabref/gui/EntryTypeView.java
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public EntryTypeView(LibraryTab libraryTab, DialogService dialogService, Prefere
ControlHelper.setAction(generateButton, this.getDialogPane(), event -> viewModel.runFetcherWorker());

setResultConverter(button -> {
// The buttonType will always be cancel, even if we pressed one of the entry type buttons
// The buttonType will always be "cancel", even if we pressed one of the entry type buttons
return type;
});

Expand Down
8 changes: 3 additions & 5 deletions src/main/java/org/jabref/gui/EntryTypeViewModel.java
Original file line number Diff line number Diff line change
Expand Up @@ -113,16 +113,14 @@ private class FetcherWorker extends Task<Optional<BibEntry>> {

@Override
protected Optional<BibEntry> call() throws InterruptedException, FetcherException {
Optional<BibEntry> bibEntry = Optional.empty();

searchingProperty().setValue(true);
storeSelectedFetcher();
fetcher = selectedItemProperty().getValue();
searchID = idText.getValue();
if (!searchID.isEmpty()) {
bibEntry = fetcher.performSearchById(searchID);
if (searchID.isEmpty()) {
return Optional.empty();
}
return bibEntry;
return fetcher.performSearchById(searchID);
}
}

Expand Down
1 change: 0 additions & 1 deletion src/main/java/org/jabref/gui/JabRefGUI.java
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ public JabRefGUI(Stage mainStage, List<ParserResult> databases, boolean isBlank,
}

private void openWindow(Stage mainStage) {

LOGGER.debug("Initializing frame");
mainFrame.init();

Expand Down
4 changes: 2 additions & 2 deletions src/main/java/org/jabref/gui/JabRefMain.java
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,8 @@ private static void applyPreferences(PreferencesService preferences) {
// Initialize protected terms loader
Globals.protectedTermsLoader = new ProtectedTermsLoader(preferences.getProtectedTermsPreferences());

// Override used newline character with the one stored in the preferences
// The preferences return the system newline character sequence as default
// Override used newline character with the one stored in the preferences.
// The preferences return the system newline character sequence as default.
OS.NEWLINE = preferences.getNewLineSeparator().toString();
}

Expand Down

0 comments on commit 71327b8

Please sign in to comment.