Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search box missing in newest version #3505

Closed
1 task done
j0hannes opened this issue Dec 9, 2017 · 15 comments
Closed
1 task done

search box missing in newest version #3505

j0hannes opened this issue Dec 9, 2017 · 15 comments
Labels
status: waiting-for-feedback The submitter or other users need to provide more information about the issue

Comments

@j0hannes
Copy link

j0hannes commented Dec 9, 2017

JabRef version 4.1-dev

Steps to reproduce:

  1. look for search box: it isn't there (see screenshots)

old version (2017-11-10):
screenshot_20171209_121417

newest version:
screenshot_20171209_121440

@Siedlerchr
Copy link
Member

Xubuntu 16.04,
javax.swing.plaf.metal.MetalLookAndFeel
image

@Siedlerchr Siedlerchr added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Dec 9, 2017
@j0hannes
Copy link
Author

j0hannes commented Dec 9, 2017

I switched to javax.swing.plaf.metal.MetalLookAndFeel now (under Arch now), but it looks different to your style:

screenshot_20171209_165315

@lenhard
Copy link
Member

lenhard commented Dec 9, 2017

@j0hannes You're not listing anything about your Java runtime. Might as well be an outdated Java runtime or outdated JavaFX.

@j0hannes
Copy link
Author

j0hannes commented Dec 9, 2017

JabRef 4.1-dev
Linux 4.9.66-1-lts amd64 
Java 1.8.0_144

@lenhard
Copy link
Member

lenhard commented Dec 10, 2017

or outdated JavaFX.

@j0hannes
Copy link
Author

where do I see that?

@tobiasdiez
Copy link
Member

You use ArchLinux, right? Then pacman -Syu should upgrade all packages (and hopefully also JavaFX). Do you use OpenJDK/OpenJFX or Oracle (java -version)?

@j0hannes
Copy link
Author

I think this is the package: extra/java-openjfx 8.u172-1 [installed]

java -version prints

openjdk version "9"
OpenJDK Runtime Environment (build 9+181)
OpenJDK 64-Bit Server VM (build 9+181, mixed mode)

but for JabRef I commented in the line in the jabref shell script that explictely makes it use version 8:
export PATH=/usr/lib/jvm/java-8-openjdk/jre/bin/:$PATH

/usr/lib/jvm/java-8-openjdk/jre/bin/java -version gives

openjdk version "1.8.0_144"
OpenJDK Runtime Environment (build 1.8.0_144-b01)
OpenJDK 64-Bit Server VM (build 25.144-b01, mixed mode)

@tobiasdiez
Copy link
Member

Thanks! That actually looks good and up-to-date. Is the SearchBar the only problem? Do the other JavaFX windows like groups, entry editor and about dialog work? Do you get an exception or some unusual print-out in the about > error console?

@j0hannes
Copy link
Author

There it is!

Uncaught exception occurred in Thread[JavaFX Application Thread,5,main]
java.lang.NullPointerException
	at org.jabref.gui.search.GlobalSearchBar.lambda$new$5(GlobalSearchBar.java:190)
	at com.sun.javafx.application.PlatformImpl.lambda$null$5(PlatformImpl.java:295)
	at java.security.AccessController.doPrivileged(Native Method)
	at com.sun.javafx.application.PlatformImpl.lambda$runLater$6(PlatformImpl.java:294)
	at com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:95)
	at com.sun.glass.ui.gtk.GtkApplication._runLoop(Native Method)
	at com.sun.glass.ui.gtk.GtkApplication.lambda$null$5(GtkApplication.java:139)
	at java.lang.Thread.run(Thread.java:748)

@tobiasdiez
Copy link
Member

tobiasdiez commented Dec 10, 2017

Ok this is helpful! Which snapshot are you using (under Help > About, should be of the form JabRef 4.1-dev--snapshot--2017-11-24--master--8025c698a). I suppose you do not use the most recent version. I changed something exactly in this line. So it would be helpful to know if you run the most recent or a previous one. Thanks!

@j0hannes
Copy link
Author

According to that dialog it's JabRef 4.1-dev. I just updated to the latest git version and the NullPointerException is still there.

@tobiasdiez
Copy link
Member

At which line? 190 or 191?

@j0hannes
Copy link
Author

190

@tobiasdiez
Copy link
Member

Thanks! I think I found the problem and a fix is in the pipeline #3512.

Siedlerchr added a commit that referenced this issue Dec 13, 2017
* upstream/master: (108 commits)
  Fetcher for IACR eprints (#3473)
  Update internal state of DatabaseChangeMonitor when external changes … (#3503)
  Fixes #3505: Another try to fix the NPE in the search bar (#3512)
  Replace ' with ' so that our HTML preview can handle it correctly
  Added a "Clear text" button in right click menu within the text boxes. (#3475)
  Add reset to English language after a test
  New translations JabRef_en.properties (German)
  Remove ampersand in non-menu localizations
  New translations JabRef_en.properties (German)
  New translations Menu_en.properties (German)
  New translations Menu_en.properties (German)
  New translations JabRef_en.properties (Vietnamese)
  New translations JabRef_en.properties (Italian)
  New translations Menu_en.properties (Italian)
  New translations JabRef_en.properties (Indonesian)
  New translations Menu_en.properties (Indonesian)
  New translations JabRef_en.properties (Greek)
  New translations Menu_en.properties (Greek)
  New translations Menu_en.properties (Japanese)
  New translations JabRef_en.properties (German)
  ...

# Conflicts:
#	build.gradle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-feedback The submitter or other users need to provide more information about the issue
Projects
None yet
Development

No branches or pull requests

4 participants