Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jabref 5.0dev does not respect the standard directory #4201

Closed
1 task
bernhard-kleine opened this issue Jul 14, 2018 · 4 comments
Closed
1 task

Jabref 5.0dev does not respect the standard directory #4201

bernhard-kleine opened this issue Jul 14, 2018 · 4 comments
Assignees
@Siedlerchr
Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor

Comments

@bernhard-kleine
Copy link

JabRef 5.0-dev--snapshot--2018-07-12--master--dd9b22911
Windows 7 6.1 amd64
Java 1.8.0_172

Steps to reproduce:

  1. load jabref 5.0dev and any library
  2. try to save a pdf entry for an entry
  3. you will notice that the path which is saved is the full path, the directory in the standard directory entry included

This is a Verschlimmbesserung, sorry for the nice German word. it means changing not for the better, but for the worth.

For first entry is manually edited, the second not
grafik
the standard directory is:
grafik
@Siedlerchr
Copy link
Member

Did you add the pdf manually or did you use a fetcher?
As far as I remember there was nothing changed in the behavior. Maybe a cleanup call is needed. I currently have the code not at hand.

@tobiasdiez tobiasdiez added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Jul 14, 2018
@bernhard-kleine
Copy link
Author

Sorry for the delay:
I used the rightclick add file for adding the pdf.

@Siedlerchr Siedlerchr self-assigned this Jul 16, 2018
@Siedlerchr
Copy link
Member

It only happens if you use Rightclick on entry -> Attach file.
Inside the General Tab it works fine.

@Siedlerchr Siedlerchr added bug Confirmed bugs or reports that are very likely to be bugs entry-editor and removed status: waiting-for-feedback The submitter or other users need to provide more information about the issue labels Jul 16, 2018
Siedlerchr added a commit that referenced this issue Jul 17, 2018
@Siedlerchr
Make attached files relative to the file directory
482e7aa 
Fixes #4201
Open files with default OS application if no External file type is present
@Siedlerchr Siedlerchr mentioned this issue Jul 17, 2018
Merged
6 tasks
Siedlerchr added a commit that referenced this issue Jul 25, 2018
@Siedlerchr
Make attached files relative to the file directory (#4212)
077fdac 
* Make attached files relative to the file directory

Fixes #4201
Open files with default OS application if no External file type is present

* add changelog

* use method from linked files view model for linked file

* fix opening of file from menu
add monadic binding

* fix variable name
@Siedlerchr
Copy link
Member

Thank you for reporting this issue. We think, that is already fixed in our development version and consequently the change will be included in the next release.

We would like to ask you to use a development build from https://builds.jabref.org/master and report back if it works for you. Please remember to make a backup of your library before trying-out this version.

@Siedlerchr Siedlerchr mentioned this issue Jul 29, 2018
Closed
1 task
@koppor koppor moved this to Done in Prioritization Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Siedlerchr Siedlerchr

Labels
bug Confirmed bugs or reports that are very likely to be bugs entry-editor
Projects
Prioritization
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Siedlerchr @tobiasdiez @bernhard-kleine