-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
possible problem with RIS publication year #4816
Comments
@CodeSJS Thanks for your report. Unfortuantely here is no attached file visible. Could you please add this? |
My apologies. I thought I dragged gzipped files into the right window. I'm new to github.
I've attached gzipped ris and bib files to this email. In the ris file, the PY and Y1 fields are both 2005, yet JabRef imports as 2019, which is the Y2 field.
Thanks,
Sherwin
On 3/28/19 7:24 AM, Christoph wrote:
@CodeSJS<https://github.com/CodeSJS> Thanks for your report. Unfortuantely here is no attached file visible. Could you please add this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#4816 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AlCPNDs94S1e_40K8OnCeosQg6YUlxk5ks5vbKYygaJpZM4cO5af>.
…--
Sherwin Singer
Department of Chemistry and Biochemistry
Ohio State University
100 W. 18th Ave.
Columbus, OH 43210
614-292-8909
www.asc.ohio-state.edu/singer.2<http://www.asc.ohio-state.edu/singer.2>
|
Hmm, I'm still not sure files are attached. I'm trying again. |
@CodeSJS Thanks! You can only add files to an issue here at github, replying via mail with attachments does not work. I could confirm the behaviour. |
Should be fixed now in the latest master, the first valid year found is now taken and no longer overwritten. We would like to ask you to use a development build from https://builds.jabref.org/master and report back if it works for you. Please remember to make a backup of your library before trying-out this version. |
Thanks for working on this. The import is now correct for the example I supplied, but it may not be a solid fix. If for some reason the Y2 field precedes Y1 or PY, then I confirmed that the JabRef development master still gets the publication year wrong. Y2 is access year, should never be imported as publication year, so I guess JabRef should ignore this field. PY, publication year, should be the desired field. Y1 is "primary date". I searched, but could not find out how primary date differs from publication year, other than is a full year-month-day. Regards, |
@CodeSJS JabRef checks multiple fields for dates: I looked and found that the original code was adapted for compatibility with a word press plugin #3634 from @dsifford Y1 and PY seem to be synonyms. jabref/src/main/java/org/jabref/logic/importer/fileformat/RisImporter.java Lines 196 to 206 in 40600b3
|
Thanks to @victorjof this issue should be already fixed in master |
JabRef version on
Steps to reproduce the behavior:
Please see the attached ris.gz file. Using either JabRef 4.3.1 or dev-5.0, JabRef imports publication year as 2019, when it is really 2005.
At first I thought it was a problem with the journal (J. Chem. Phys.) web site. Then I saw that the Y1 and PY fields in the ris file were correctly set to 2005. The Y2 field is 2019, but that is supposed to be the access date.
The bib file works fine, since it does not contain a field for access date.
Please let me know if the problem is really with the journal after all, and I'll communicate with them.
Thanks for JabRef!
Log File
The text was updated successfully, but these errors were encountered: