Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog close after pressing ok button #4857

Closed
Ali96kz opened this issue Apr 6, 2019 · 1 comment
Closed

Dialog close after pressing ok button #4857

Ali96kz opened this issue Apr 6, 2019 · 1 comment

Comments

@Ali96kz
Copy link
Contributor

Ali96kz commented Apr 6, 2019

Steps to reproduce:

  1. File -> Connect to shared database
  2. Enter wrong database password
  3. You will see error. When you close or press ok the connect to database dialog will close too.

Screenshot 2019-04-06 at 22 49 53
@harinda05 harinda05 mentioned this issue Apr 16, 2019
Merged
6 tasks
tobiasdiez pushed a commit that referenced this issue Apr 17, 2019
@harinda05 @tobiasdiez
Fixed Closing of the Shared Database Login Dialog if the user enters …
6fd0102 
…wrong authentication details - #4857 (#4892)

* Fix for the issue - #4783 Group creation not possible anymore with default settings

* Changed the position of the listeners and onaction replaced with changelistener

* Removed changelog entry

* Fix for issue 4783 - Simplified listeners in to lambdas

* Update GroupDialog.java

* Fixed shared db dialog close when incorrect authentication details

* Changed Boolean in to boolean as requested changes - SharedDatabaseLoginDialog
@tobiasdiez
Copy link
Member

Thanks to @harinda05 this should be fixed in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.

Siedlerchr added a commit that referenced this issue Apr 18, 2019
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into pushtoApplication
b40e511 
* upstream/master:
  Add option for direct attached file renaming (#4887)
  Fixed Closing of the Shared Database Login Dialog if the user enters wrong authentication details - #4857 (#4892)

# Conflicts:
#	src/main/resources/l10n/JabRef_en.properties
@koppor koppor moved this to Done in Prioritization Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Prioritization
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tobiasdiez @Ali96kz