importBibtex imports to an untitled library in a new instance

[LyzardKing]

As the title suggests, with the recent jabref updates the --importBibtex option opens a new instance of JabRef, and automatically adds the reference to a new "untitled" library.
Last time I used this functionality it asked confirmation and added to the running Jabref and lib.

[Siedlerchr]

A quick look in the code reveals that it checks if there is a currentBasePanel active.
I guess the base panel is not yet there due to the lazy loading stuff

[LyzardKing]

And that should work for the untitled library, but why is it launching another instance in the first place?
Should the cli part not look for an open instance in the first place?

[Siedlerchr]

The point for debugging would be:

jabref/src/main/java/org/jabref/cli/ArgumentProcessor.java

Lines 87 to 98 in f14b12b

	private static Optional<ParserResult> importBibtexToOpenBase(String argument) {
	BibtexParser parser = new BibtexParser(Globals.prefs.getImportFormatPreferences(), Globals.getFileUpdateMonitor());
	try {
	List<BibEntry> entries = parser.parseEntries(argument);
	ParserResult result = new ParserResult(entries);
	result.setToOpenTab();
	return Optional.of(result);
	} catch (ParseException e) {
	System.err.println(Localization.lang("Error occurred when parsing entry") + ": " + e.getLocalizedMessage());
	return Optional.empty();
	}
	}

[LyzardKing]

This is still an issue in the last builds...
I'm not sure how to debug this.
Is the open instance of jabref be set by line 92 (result.setToOpenTab();)?

[tobiasdiez]

Yes, I guess that libraries with setToOpenTab are opened as new tabs. It might be sufficient to simply remove that line...

(You can debug this by adding command line arguments to the start configuration in IntelliJ.)

[LyzardKing]

Removing that line makes no difference..
I wonder why the open instance of jabref is not being recognized any more..

[Siedlerchr]

Have you checked that it's enabled in the preferences? e.g. allow only a single instance of jabref?

[LyzardKing]

@Siedlerchr Do you mean the remote operation option in advanced?
It's checked, but on linux it never made a difference.
(I noticed I forgot to add the os to the original post..)

[LyzardKing]

I get the same issue if I --importToOpen file.bib
It always opens a new instance of JabRef..

[LyzardKing]

This issue apparently only applies to the deb install.
The rpm works properly..
EDIT: The snap also works.. there's something wrong with the deb. I tried a vm as well to rule out my system, and I get the same issue..

[tobiasdiez]

This should be fixed in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.

[LyzardKing]

I tried the latest build from master and it behaves the same, opening a new blank window.
This time it doesn't add the reference to the new blank window, but neither to the original window..
So I'm left with the original unchanged bib window, and a blank one, with no tab open.

[tobiasdiez]

Do you start with having an instance of JabRef open?

[LyzardKing]

Yes, i have the open instance with my bibliography file active

[tobiasdiez]

ok, than this is another bug. What I fixed was that starting a new instance with the cmd option works as expected.

[LyzardKing]

So with this fix it should work if I don't have an instance open already?