Font size increase does not increase preferences font size

[koppor]

[LuckyOne09]

Hi, I found something strange when I try to reproduce this bug. If I increase the font size too large, then the UI will be like this:

You can see when font size is too large, there is no menu displaying above. Hence, it will be very difficult to find what I want(In fact, I spent long time to try to find preference tab again.). So I guess that it may be another bug?

[LuckyOne09]

Hi，@koppor

I have been working on this for a long time. I feel that I have found some useful things. But I am still confused about some implementations of JabRef.
I found that in the ThemeLoader.java, there are codes that are responsible for changing the font-size according to JabRefPreferences.

jabref/src/main/java/org/jabref/gui/util/ThemeLoader.java

Lines 75 to 84 in 7cb7ea6

	/**
	* Installs the base css file as a stylesheet in the given scene. Changes in the css file lead to a redraw of the
	* scene using the new css file.
	*/
	public void installCss(Scene scene, JabRefPreferences preferences) {
	addAndWatchForChanges(scene, JabRefFrame.class.getResource(MAIN_CSS), 0);
	additionalCssToLoad.ifPresent(file -> addAndWatchForChanges(scene, file, 1));
	preferences.getFontSize().ifPresent(size -> scene.getRoot().setStyle("-fx-font-size: " + size + "pt;"));
	}

I guess that the cause of this bug is that these codes only change the font size of elements in root. But like elements in Apperance tab, they are in other more specific style class.

jabref/src/main/java/org/jabref/gui/preferences/AppearanceTab.fxml

Lines 17 to 19 in 7cb7ea6

	<Label styleClass="titleHeader" text="%Appearance"/>
	<Label styleClass="sectionHeader" text="%Font"/>

Therefore, I think that is why the font size change in root can't affect the preferences font size. (By the way, except preferences dialog, nearly every dialog suffer this bug.)

I tried to get the specific style class of preferences dialog,so I added codes in Themeloader.java to solve this problem like that:

Unluckily, it didn't work.

I am wandering now...... So I will appreciate you very much if you could give me some hints or suggestions.

[Siedlerchr]

Hi, maybe that helps: The PreferencesDialog has it's own CSS file, I am not sure how it's overriden or related to the main file
https://github.com/JabRef/jabref/blob/master/src/main/java/org/jabref/gui/preferences/PreferencesDialog.css

[LuckyOne09]

Hi,@Siedlerchr
Thanks for your help.
But I found that there are no invocation to add PreferencesDialog.css to any scene.

And in the PreferencesDialog, there are no settings about font size. Therefore, it seems that it is not useful for fixing this bug?

[LuckyOne09]

Now, we guess that maybe the cause is that when click Preferences.
many scenes will be created according to the codes:

jabref/src/main/java/org/jabref/gui/preferences/PreferencesDialogViewModel.java

Lines 39 to 61 in 7cb7ea6

	public PreferencesDialogViewModel(DialogService dialogService, JabRefFrame frame) {
	this.dialogService = dialogService;
	this.preferences = Globals.prefs;
	this.frame = frame;
	preferenceTabs = FXCollections.observableArrayList(
	new GeneralTabView(preferences),
	new FileTabView(preferences),
	new TableTabView(preferences),
	new TableColumnsTabView(preferences),
	new PreviewTabView(preferences),
	new ExternalTabView(preferences, frame),
	new GroupsTabView(preferences),
	new EntryEditorTabView(preferences),
	new BibtexKeyPatternTabView(preferences),
	new ImportTabView(preferences),
	new ExportSortingTabView(preferences),
	new NameFormatterTabView(preferences),
	new XmpPrivacyTabView(preferences),
	new AdvancedTabView(preferences),
	new AppearanceTabView(preferences)
	);
	}

And we guess that these new scenes don't install css. Therefore we add some codes in

jabref/src/main/java/org/jabref/gui/preferences/PreferencesDialogView.java

Line 113 in 7cb7ea6

void showAllPreferences() { viewModel.showPreferences(); }

we change it to this:

    @FXML
    void showAllPreferences() {
        preferenceTabList.getItems().forEach(tab -> Globals.getThemeLoader().installCss(tab.getBuilder().getScene(), Globals.prefs));
        viewModel.showPreferences();
    }

But it does not work again. So, I want to ask if there are some misunderstanding I have here?

Thanks very much for your patience and kindness