-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icon picker in group edit dialog #6142
Comments
This issue has been inactive for half a year. Since JabRef is constantly evolving this issue may not be relevant any longer and it will be closed in two weeks if no further activity occurs. As part of an effort to ensure that the JabRef team is focusing on important and valid issues, we would like to ask if you could update the issue if it still persists. This could be in the following form:
Thank you for your contribution! |
Refs #7058 |
As the switch from fontawesomefx to Ikonli is now finished it should be relatively easy to implement an icon picker dialog. |
I would like to work on this issue can you please elaborate what is to be done? |
I want to participate in GSOC 2021, so I would like to work on this issue with dropdown icon combobox as suggested by @tobiasdiez @Siedlerchr |
@srdeotarse Thanks for your interest! @aakarshvats638 do you still plan to work on this, or even already started? |
Hi! We are a group of 4 students from the University of Adelaide, and we are learning to contribute to open source projects. Is anyone currently working on this issue? If not, we'd like to help with this issue. Any guidance would be appreciated. Cheers! |
|
That looks very nice! Good job. Concerning the performance problem, how did you implement the grid? It might be necessary to use something like https://github.com/FXMisc/Flowless to not create 1000 buttons but only a couple (essentially what fits in the display) and reuse them when scrolling. I would suggest you open a draft PR where we can discuss these things. |
8d69f16 Create university-of-hull-harvard.csl (#6146) 139dfdd Create current organic synthesis.csl (#6139) bb006c8 Update acta-universitatis-agriculturae-sueciae.csl (#6143) 5815da0 Create food-science-and-biotechnology.csl (#6132) 2702a7c Update harvard-university-for-the-creative-arts.csl (#6104) ef34543 Update economic-geology.csl (#6128) 0adcd30 Bump mathieudutour/github-tag-action from 5.6 to 6.0 (#6141) 3c36e97 Create universite-du-quebec-a-montreal-prenoms.csl (#6073) 415bc05 Bump softprops/action-gh-release from 0.1.14 to 1 (#6142) ae8c5e4 Create politique-europeenne.csl (#6074) 09cbc09 Update cell-numeric-superscript.csl (#6188) 6ee1ace Update avian-conservation-and-ecology.csl (#6191) cb5c43f Update harvard-anglia-ruskin-university.csl (#6189) 5c4f4c0 Create anais-da-academia-brasileira-de-ciencias.csl (#6066) a60dfe9 Update cardiff-university-harvard.csl (#6190) 999a45c Create sociologia-urbana-e-rurale.csl (#6042) 1bc9d62 Bluebook (#6183) a4f2a72 Oxford Brookes (#6182) 88df8d5 Delete harvard-cardiff-university-old.csl (#6180) b9302fd Update APA styles for "event" macro (#6174) d4daec6 remove DOI for printed articles organizational-studies.csl (#6176) acfc620 Create liver-transplantation.csl (#6167) 129a775 Change "event" to "event-title" (#6164) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 8d69f16
As noted recently, the user has to manually lookup the icon-code and put it in the "Edit group" dialog. Instead, we should show a (searchable) list of all available icons.
Example for how the UI can look like: https://itsjavi.com/fontawesome-iconpicker/ (and maybe https://dmdc0de.github.io/material-ui-icon-picker/ )
Example code for a similar implementation in JavaFX: https://github.com/kordamp/ikonli/blob/18b3fb679d358801f5730352014cdbc780aff31a/apps/sampler-javafx/src/main/java/org/kordamp/ikonli/sampler/javafx/Sampler.java#L131-L153
The text was updated successfully, but these errors were encountered: