Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add subgroup" dialog should not start with focus on OK button #6307

Closed
mpatas opened this issue Apr 18, 2020 · 4 comments · Fixed by #6330
Closed

"Add subgroup" dialog should not start with focus on OK button #6307

mpatas opened this issue Apr 18, 2020 · 4 comments · Fixed by #6330
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. groups type: enhancement ui

Comments

@mpatas
Copy link

mpatas commented Apr 18, 2020

Using JabRef 5.0, when one creates a subgroup (right clicking on a group and choosing "Add subgroup"), the dialog "Add subgroup" is shown, and it has focus on "OK" button. That seems to be wrong, for there seems to be no reason to press that button at that time. I'd say that field "Name" should have focus when the dialog is created, for name is required for subgroup anyway.

@Siedlerchr Siedlerchr added good first issue An issue intended for project-newcomers. Varies in difficulty. groups type: enhancement ui labels Apr 19, 2020
@HussainArif12
Copy link
Contributor

I want to commit to this issue. Are there any code files I should change?

@Siedlerchr
Copy link
Member

@Siedlerchr
Copy link
Member

Thanks to @HussainArif12 This issue should be fixed now in the latest master. Should be available in half an our or so.

We would like to ask you to use a development build from https://builds.jabref.org/master and report back if it works for you. Please remember to make a backup of your library before trying-out this version.

@HussainArif12
Copy link
Contributor

HussainArif12 commented Apr 21, 2020 via email

koppor pushed a commit that referenced this issue Jan 1, 2023
43566f2 Update molecular-oncology.csl (#6354)
38f2b5f Update san-francisco-estuary-and-watershed-science.csl (#6350)
724cb12 Update australasian-journal-of-philosophy.csl (#6344)
df6af86 Fix webpage in-text citation for council-of-science-editors-author-date.csl (#6318)
6900b58 Add month to magazine for Bluebook
e0a8148 Update cambridge-university-press-author-date-cambridge-a.csl (#6345)
0823448 Add space & comma before pp (#6343)
ff38cd2 Update american-journal-of-respiratory-and-critical-care-medicine.csl (#6341)
8727dfb Update early-music-history.csl (#6323)
1154354 Update boletin-de-pediatria.csl (#6310)
f25438e Update pravnik.csl (#6309)
db7a4ae Update zoological-journal-of-the-linnean-society.csl (#6304)
6c043a7 Create polygraphia.csl (#6307)
255e00c Create intellect-newgen-books.csl (#6308)
323629f Update historical-materialism.csl (#6300)
f62b70d Create european-review-of-international-studies.csl (#6301)
dff2698 Update ucl-university-college-harvard.csl (#6298)
0ce09c9 Update sciences-po-ecole-doctorale-note-french.csl (#6290)
bdd53ec Update sciences-po-ecole-doctorale-author-date.csl (#6291)
efde4d4 Create journal-of-law-medicine-ethics.csl (#6296)
7539b2c Create theses-de-sorbonne-universite.csl (#6295)
905f25a Update biochemical-society-transactions.csl (#6292)
a76a3f5 Update smithsonian-institution-scholarly-press author-date and note (#6294)
e6b6c6c Create exploration-of-targeted-anti-tumor-therapy.csl (#6276)
024c9c8 Create nys-nydanske-studier.csl (#6331)
d9ac8e1 Update vox-sanguinis.csl (#6327)
9a98e92 Remove DOI from Genetics & Molecular Biology

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 43566f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. groups type: enhancement ui
Projects
Archived in project
3 participants