Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for the Entry Preview #7083

Closed
AtrusRiven opened this issue Nov 7, 2020 · 7 comments
Closed

Improvements for the Entry Preview #7083

AtrusRiven opened this issue Nov 7, 2020 · 7 comments

Comments

@AtrusRiven
Copy link
Contributor

AtrusRiven commented Nov 7, 2020

The preview does not differentiate between different entry types. Of course, there’s the possiblity to display the entries in a certain citation style that employs this differentiation, but in my opinion, the preview display should be independent from the citation styles. No differentiating between entry types, thus, results in an ambiguous display in some cases, crossing the metadata’s logical order, for example with InCollection:
preview
With the sequence:

  1. Author
  2. Editor
  3. Title (< Author)
  4. Booktitle (< Editor)

The preview should be conditional upon the entry type, so that in this example the sequence would be:

  1. Author
  2. Title (< Author)
  3. Editor
  4. Booktitle (< Editor)

In general, the logical order should differentiate between the containing and the contained bibliographical element. Thus, this new logical order would be (the following covers the most important entry types and doesn’t claim completeness):

entrytype logical order of metadata elements
Book 1. Author
2. Title
3. Year
Collection 1. Editor (Ed.)
2. Title
3. Year
Article and InCollection 1. Author
2. Title
3. Year

4. Editor (Ed.)
5. Booktitle

Moreover, the preview could be more complete and well-arranged in displaying the entry’s metadata, for example:
preview_new

Would it be possible to substitute the default preview style with something like this (code for this preview styling)?

@koppor
Copy link
Member

koppor commented Nov 10, 2020

When using citation styles, you get the style-dependend preview for free (no documentation for JabRef existing yet --> https://docs.jabref.org/collaborative-work/export/customexports). We know that not all fields are available there.

Future work:

@AtrusRiven
Copy link
Contributor Author

Thanks for the quick reply!

My idea was to make the default preview (which already is independent from citation styles) more suitable without the necessity to adjust the citation style for the adjustments of these styles are non-trivial if you want to have them to be really consistent. A complete and consistent preview by default could help a lot, especially to those who do not work with automated citation styles. For example, in the historic or "classic" humanities there are way to many special cases and exceptions when it comes to older literature.

@koppor
Copy link
Member

koppor commented Nov 10, 2020

I have to think how to include localization in the preview

IfPlural(Hgg.,Hg.)

Think, in English, this is Eds.,Ed..

@koppor koppor mentioned this issue Nov 10, 2020
5 tasks
@AtrusRiven
Copy link
Contributor Author

I have to think how to include localization in the preview

IfPlural(Hgg.,Hg.)

Think, in English, this is Eds.,Ed..

Localization wouldn't be the priority in my opinion (even though very useful). We could just include Eds.,Ed., and everyone could make his own localization if preferred (in case implementation of localization might be relatively too laborious).

@AtrusRiven
Copy link
Contributor Author

Made some improvements for the entry preview that should be more entry type sensitive.

Siedlerchr pushed a commit that referenced this issue Dec 19, 2020
…on to #7093) (#7185)

* Update JabRefPreferences.java

Modifications in Entry Preview (7093 and 7083)

* Update JabRefPreferences.java

Minor Correction

* Additions for #7185

"=" deleted
Siedlerchr added a commit that referenced this issue Dec 21, 2020
* upstream/master: (33 commits)
  Bump archunit-junit5-api from 0.14.1 to 0.15.0 (#7220)
  Bump unoloader from 7.0.3 to 7.0.4 (#7214)
  Bump guava from 30.0-jre to 30.1-jre (#7218)
  Bump xmpbox from 2.0.21 to 2.0.22 (#7217)
  Bump classgraph from 4.8.94 to 4.8.97 (#7211)
  Bump byte-buddy-parent from 1.10.18 to 1.10.19 (#7216)
  Bump archunit-junit5-engine from 0.14.1 to 0.15.0 (#7215)
  Bump org.beryx.jlink from 2.22.3 to 2.23.0 (#7212)
  Add missing author
  Remove field check for journal abbrev in entry editor (#7208)
  Improvements for Entry Preview (in the context of #7083 and in addition to #7093) (#7185)
  Fix pdf content importer exception if DOI is empty (#7207)
  New translations JabRef_en.properties (Turkish) (#7204)
  New Crowdin updates (#7198)
  New Crowdin updates (#7192)
  Added missing test
  Changed tests to parameterized tests
  Extraction of Globals.prefs.put and .get (#7121)
  Fix newly added entry not synced to db (#7178)
  Bump org.eclipse.jgit from 5.9.0.202009080501-r to 5.10.0.202012080955-r (#7187)
  ...
@AtrusRiven
Copy link
Contributor Author

Is there yet something open in this issue? There is another commit but as far as I have seen the actual release client, everything works as expected.

@koppor
Copy link
Member

koppor commented Jun 13, 2022

@AtrusRiven Thank you for reporting back. Since you are the issue author and state that everything is fixed, I'll close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants