Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Dark theme: "Add group" button seems inactivated #8051

Closed
2 tasks done
mlep opened this issue Sep 2, 2021 · 13 comments · Fixed by #8392
Closed
2 tasks done

UI: Dark theme: "Add group" button seems inactivated #8051

mlep opened this issue Sep 2, 2021 · 13 comments · Fixed by #8392
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. groups ui

Comments

@mlep
Copy link
Contributor

mlep commented Sep 2, 2021

JabRef version

Latest development branch build (please note build date below)

Operating system

GNU / Linux

Details on version and operating system

JabRef 5.4--2021-09-01--69550d3 Linux 4.19.0-17-amd64 amd64 Java 16.0.2 JavaFX 16+8

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behavior

In dark theme:

  • At the bottom of the group interface, the button Add group is, at first, very visible (too much I would say):
    ksnip_20210902-093301

  • Then (after some time, or after creating a subgroup?), the appearance of this button is modified, and it looks like it is inactivated (black characters on grey background):
    ksnip_20210902-093559

I would expect the Add group button to look like the Search button.

Appendix

...

Log File ``` Paste an excerpt of your log file here ```
@mlep mlep changed the title UI: Dark mode: "Add group" button seems inactivated UI: Dark theme: "Add group" button seems inactivated Sep 2, 2021
@Siedlerchr Siedlerchr added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Sep 26, 2021
@berry120
Copy link
Contributor

berry120 commented Oct 1, 2021

I thought I might have a look at this one, but I can't actually reproduce it - I've tried waiting a while then creating a subgroup, or just creating a whole bunch of groups - but I never get the issue where the button is disabled.

Has anyone else had any joy in reproducing this and if so, are there any specific steps? Thanks!

@mlep
Copy link
Contributor Author

mlep commented Oct 4, 2021

@berry120 The button is not really disabled. It just looks like it is disable.
And I do not know which criteria makes the button appearance change. It is coded somewhere. If I recall correctly, the very visible button was designed to attract attention to new users.

@berry120
Copy link
Contributor

berry120 commented Oct 4, 2021

@mlep I also haven't been able to reproduce the behaviour where the button looks disabled while it's not I'm afraid - though I'm only on Windows, so it's possible it's a platform specific thing maybe?

@mlep
Copy link
Contributor Author

mlep commented Oct 4, 2021

@berry120: I found the information that should allow you to see a different button: the button should change appearance after creating 10 groups (#7714)

The disabled (bad) look maybe Linux-specific.
Maybe windows beneficiate of a better look (but I cannot test on windows).

@srshiao
Copy link

srshiao commented Oct 16, 2021

I was able to reproduce this behavior on Windows, but am I understanding that this is an intended feature or is there still a fix that needs to be made here?

@mlep
Copy link
Contributor Author

mlep commented Oct 17, 2021

It is intended that the button change in appearance.
What is not intended it that, afterwards, the button looks deactivated.
The "Add group" button should look like the "Search" button located at the bottom of the screenshot.

@srshiao
Copy link

srshiao commented Oct 30, 2021

Got it, I can try to do that!

@dimitrisdimos00
Copy link
Contributor

dimitrisdimos00 commented Jan 4, 2022

Hello! Is this issue fixed? I think I have managed to tackle it, if @srshiao hasn't already. Take a look.
image
I don't know though if this functionality (e.g. the button to change color after inserting 10 groups) is necessary. You have the last word however.

@mlep
Copy link
Contributor Author

mlep commented Jan 5, 2022

It seems that @srshiao has lost interest. So, you are free to propose a PR.

Personally, I find the change in color after 10 inserted groups more disturbing than useful (and, to my knowledge, this is an oddity in JabRef since it occurs only for this feature). @Siedlerchr : What do you think?

@Siedlerchr
Copy link
Member

Yes, I agree with you @mlep

dimitrisdimos00 added a commit to dimitrisdimos00/jabref that referenced this issue Jan 5, 2022
…er changed the text color from white to background color. Changed the method setNewGroupButtonStyle of class GroupTreeView.

fixes JabRef#8051
dimitrisdimos00 added a commit to dimitrisdimos00/jabref that referenced this issue Jan 5, 2022
@tobiasdiez
Copy link
Member

The idea was that new users learn to find the "new group" button, and once they know where it is the visual highlight is no longer necessary. I cannot found the PR where this was added, but there was some discussion about this already.

dimitrisdimos00 added a commit to dimitrisdimos00/jabref that referenced this issue Jan 5, 2022
…utton in GroupTree.css. Deleted method setNewGroupButtonStyle brcause the button is unstylized.

fixes JabRef#8051
dimitrisdimos00 added a commit to dimitrisdimos00/jabref that referenced this issue Jan 5, 2022
…utton in GroupTree.css. Deleted method setNewGroupButtonStyle as the button is unstylized.

fixes JabRef#8051
dimitrisdimos00 added a commit to dimitrisdimos00/jabref that referenced this issue Jan 6, 2022
dimitrisdimos00 added a commit to dimitrisdimos00/jabref that referenced this issue Jan 6, 2022
dimitrisdimos00 added a commit to dimitrisdimos00/jabref that referenced this issue Jan 6, 2022
@Siedlerchr
Copy link
Member

@dimitrisdimos00 Thanks again for your contribution! Included in the newest Bugfix release as well.

@dimitrisdimos00
Copy link
Contributor

Happy to help!

@koppor koppor moved this to Done in Prioritization Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. groups ui
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants