-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Dark theme: "Add group" button seems inactivated #8051
Comments
I thought I might have a look at this one, but I can't actually reproduce it - I've tried waiting a while then creating a subgroup, or just creating a whole bunch of groups - but I never get the issue where the button is disabled. Has anyone else had any joy in reproducing this and if so, are there any specific steps? Thanks! |
@berry120 The button is not really disabled. It just looks like it is disable. |
@mlep I also haven't been able to reproduce the behaviour where the button looks disabled while it's not I'm afraid - though I'm only on Windows, so it's possible it's a platform specific thing maybe? |
I was able to reproduce this behavior on Windows, but am I understanding that this is an intended feature or is there still a fix that needs to be made here? |
It is intended that the button change in appearance. |
Got it, I can try to do that! |
Hello! Is this issue fixed? I think I have managed to tackle it, if @srshiao hasn't already. Take a look. |
It seems that @srshiao has lost interest. So, you are free to propose a PR. Personally, I find the change in color after 10 inserted groups more disturbing than useful (and, to my knowledge, this is an oddity in JabRef since it occurs only for this feature). @Siedlerchr : What do you think? |
Yes, I agree with you @mlep |
…er changed the text color from white to background color. Changed the method setNewGroupButtonStyle of class GroupTreeView. fixes JabRef#8051
The idea was that new users learn to find the "new group" button, and once they know where it is the visual highlight is no longer necessary. I cannot found the PR where this was added, but there was some discussion about this already. |
…utton in GroupTree.css. Deleted method setNewGroupButtonStyle brcause the button is unstylized. fixes JabRef#8051
…utton in GroupTree.css. Deleted method setNewGroupButtonStyle as the button is unstylized. fixes JabRef#8051
@dimitrisdimos00 Thanks again for your contribution! Included in the newest Bugfix release as well. |
Happy to help! |
JabRef version
Latest development branch build (please note build date below)
Operating system
GNU / Linux
Details on version and operating system
JabRef 5.4--2021-09-01--69550d3 Linux 4.19.0-17-amd64 amd64 Java 16.0.2 JavaFX 16+8
Checked with the latest development build
Steps to reproduce the behavior
In dark theme:
At the bottom of the group interface, the button
Add group
is, at first, very visible (too much I would say):Then (after some time, or after creating a subgroup?), the appearance of this button is modified, and it looks like it is inactivated (black characters on grey background):
I would expect the
Add group
button to look like theSearch
button.Appendix
...
Log File
``` Paste an excerpt of your log file here ```The text was updated successfully, but these errors were encountered: