Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing several groups deletes only one of them #8390

Closed
2 tasks done
mlep opened this issue Jan 5, 2022 · 3 comments · Fixed by #8801 or #8875
Closed
2 tasks done

Removing several groups deletes only one of them #8390

mlep opened this issue Jan 5, 2022 · 3 comments · Fixed by #8801 or #8875
Labels
component: groups [outdated] type: enhancement

Comments

@mlep
Copy link
Contributor

mlep commented Jan 5, 2022

JabRef version

Latest development branch build (please note build date below)

Operating system

GNU / Linux

Details on version and operating system

JabRef 5.5--2022-01-03--c94bb1b Linux 4.19.0-18-amd64 amd64 Java 16.0.2 JavaFX 17.0.1+1

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Create several groups
  2. Select them
  3. Right click on the selection and choose Remove groups > Also remove subgroups in the drop-down menu

You are prompted to confirm the deletion of one group. After accepting, this group is deleted, but you are not prompted to delete the other groups.
So, while it seems that several can be removed at the same time, groups can be removed only one by one.

Appendix

...

Log File 
Paste an excerpt of your log file here
@ThiloteE ThiloteE mentioned this issue May 15, 2022
Closed
6 tasks
@LIM0000 LIM0000 mentioned this issue May 16, 2022
Merged
6 tasks
@mlep
Copy link
Contributor Author

mlep commented May 31, 2022

Thank you @LIM0000 for your PR.
Indeed, this solves the issue for Remove groups > Also remove subgroups.
However, a similar issue remains for Remove groups > Keep subgroups.
Please, could you look at this closely-related issue?

LIM0000 added a commit to LIM0000/jabref that referenced this issue May 31, 2022
@LIM0000
Fix JabRef#8390 by allowing multiple group deletion for Remove groups…
66cacb4 
… > Keep subgroups
@LIM0000 LIM0000 mentioned this issue May 31, 2022
Merged
6 tasks
@LIM0000
Copy link
Contributor

LIM0000 commented May 31, 2022 •
edited
Loading

Hi @mlep , I have raised a PR to allow multiple deletion for Remove groups > Keep subgroups as well.
Cheers.

@mlep
Copy link
Contributor Author

mlep commented May 31, 2022

@LIM0000 Thank you for this very quick follow-up!

Siedlerchr pushed a commit that referenced this issue May 31, 2022
@LIM0000
Fix #8390 by allowing multiple group deletion for Remove groups > Kee… (
538843a 
#8875)

* Fix #8390 by allowing multiple group deletion for Remove groups > Keep subgroups

* Update english localization file

* Update src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java
Siedlerchr added a commit that referenced this issue Jun 1, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fileManager
bca0ac8 
* upstream/main:
  Add an importer for Citavi backup files (#8848)
  Reviewdoc: Comment on PRs (#8878)
  Squashed 'buildres/csl/csl-styles/' changes from 649aac4..e740261
  Use JDK 15 text blocks to improve injected languages readability (#8874)
  Fix fetcher tests (#8877)
  Fix #8390 by allowing multiple group deletion for Remove groups > Kee… (#8875)
  Add restart warning on SSL configuration change (#8871)
  Update to lucene 9.2 (#8868)
  Fix for removing several groups deletes only one of them (#8801)
  Disable Write XMP Button in General tab of Entry-Editor when action is in progress (#8728)
  Bump jsoup from 1.14.3 to 1.15.1 (#8864)
  Bump unirest-java from 3.13.8 to 3.13.10 (#8869)
  Bump unoloader from 7.3.2 to 7.3.3 (#8863)
  Bump pascalgn/automerge-action from 0.15.2 to 0.15.3 (#8860)
  Bump classgraph from 4.8.146 to 4.8.147 (#8861)
  Bump mockito-core from 4.5.1 to 4.6.0 (#8862)
  Lucence dir checkers should only delete lucence dirs (#8854)
  Update README.md (#8858)
  Update adr.md
  Update adr.md
@Gpax971 Gpax971 mentioned this issue Oct 22, 2022
Closed
2 tasks
@LDeolindo LDeolindo mentioned this issue Dec 1, 2022
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: groups [outdated] type: enhancement
Projects
Features & Enhancements
Archived in project
Milestone
No milestone
3 participants
@Siedlerchr @mlep @LIM0000