Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOAB fetcher does not fetch field ISBN #8708

Closed
2 tasks done
ThiloteE opened this issue Apr 20, 2022 · 7 comments · Fixed by #9229
Closed
2 tasks done

DOAB fetcher does not fetch field ISBN #8708

ThiloteE opened this issue Apr 20, 2022 · 7 comments · Fixed by #9229
Assignees
Labels
fetcher good first issue An issue intended for project-newcomers. Varies in difficulty.

Comments

@ThiloteE
Copy link
Member

JabRef version

Latest development branch build (please note build date below)

Operating system

Windows

Details on version and operating system

No response

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

See this entry: https://directory.doabooks.org/handle/20.500.12854/35818

Search for "Accounts and Accountability in Late Medieval Europe" in JabRef DOAB websearch.

It finds:

@Book{EpurescuPascovici2020aaa,
  date      = {2020},
  title     = {Accounts and Accountability in Late Medieval Europe},
  doi       = {10.1484/M.USML-EB.5.119569},
  editor    = {Ionuț Epurescu-Pascovici},
  language  = {English},
  pages     = {318},
  publisher = {Brepols},
  subtitle  = {Records, Procedures, and Socio-Political Impact},
  url       = {http://library.oapen.org/handle/20.500.12657/39752},
  abstract  = {This volume stems from a conference organised in November 2018 at the
University of Bucharest in the frame of the European Research Council
project CASTELLANY ACCOUNTS, “Record-keeping, fiscal reform, and
the rise of institutional accountability in late-medieval Savoy: A source-oriented
approach”. Both the conference and the volume have received funding
from the European Research Council (ERC) under the European Union’s Horizon
2020 research and innovation programme (grant agreement No. 638436).
The volume traces the momentous transformation of institutions and administration under the impact of accounting records and procedures, c. 1250-1500. The focus on the materiality and organising logic of a range of accounts is complemented by close attention to the socio-political contexts in which they functioned and the agency of central and local officials.},
  keywords  = {middle ages, Europe, auditing, accounts, HB},
  uri       = {https://directory.doabooks.org/handle/20.500.12854/35818},
}

The ISBN field is missing.

Additional info:

code can be found here: src/main/java/org/jabref/logic/importer/fetcher/DOABFetcher.java

Appendix

No response

@ThiloteE
Copy link
Member Author

This is a follow up to #8576

@Siedlerchr
Copy link
Member

Looked into it: The API result does not contain the ISBN number as field https://directory.doabooks.org/rest/search?query=%22i+open+fire%22&expand=metadata

@ThiloteE
Copy link
Member Author

@RonaldSnijder is there a specific reason for this? Would it be possible to add the ISBN (oapen.relation.isbn) to the fields offered by the API? I feel bad for JabRef users fetching incomplete bibliographic metadata.

Another field that does not seem to be present: oapen.imprint. There might be more, but these are the two I noticed when testing the new DOAB fetcher.

@RonaldSnijder
Copy link

RonaldSnijder commented May 6, 2022

@ThiloteE Hi, there are two questions here, I think:

  1. Where can I find the ISBNs? In short, the ISBN is part of the metadata connected to the BITSTREAM. There might also be additional ISBNs in oapen.relation.isbn; dc.identifier.isbn
  2. How can I access a filed like"oapen.imprint"? These fields - when they are part of the record - can be accessed via the API

Perhaps you can take a look here:
https://directory.doabooks.org/rest/search?query=handle:%2220.500.12854/26303%22&expand=metadata,bitstreams

Both issues are addressed.
Hope this helps!

@ThiloteE ThiloteE added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Jun 16, 2022
@shafinkamal
Copy link
Contributor

G'day! I'm a new contributor and I would like to a make an attempt at fixing this issue. I have read the developer contribution page and have setup an IntelliJ environment for local JabRef development as per the instructions.

I was hoping someone could point me in the right direction as to where to begin solving the issue?

Thanks!

@ThiloteE
Copy link
Member Author

ThiloteE commented Oct 9, 2022

Hi @shafinkamal yes, you are welcome. If you look at how the other fields (e.g. title, date, pages etcetera) are implemented and fetched, you might be able to add the ISBN field similarly. If you read carefully, I think most, if not all relevant information to solve this issue has already been presented in previous comments. A first step would be to look at the code of the previous pull-request that implemented the DOAB fetcher.

@shafinkamal
Copy link
Contributor

  1. Where can I find the ISBNs? In short, the ISBN is part of the metadata connected to the BITSTREAM. There might also be additional ISBNs in oapen.relation.isbn; dc.identifier.isbn

Hi @RonaldSnijder,

Thank you for your comment. I note that in an example query:

https://directory.doabooks.org/rest/search?query=%22i+open+fire%22&expand=metadata,bitstreams

There is no metadata relating to the ISBN within the connected BITSTREAM as you have suggested. I was wondering if you knew if there was another way to observe the metadata to obtain the ISBN?

Thanks,
Shafin

shafinkamal added a commit to shafinkamal/jabref that referenced this issue Oct 10, 2022
This commit modifies the URL for DOAB query to include `BITSTREAM` data. The fetcher can then obtain the ISBN and add the field to the entry accordingly. fixes JabRef#8708.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fetcher good first issue An issue intended for project-newcomers. Varies in difficulty.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants