-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOAB fetcher does not fetch field ISBN #8708
Comments
This is a follow up to #8576 |
Looked into it: The API result does not contain the ISBN number as field https://directory.doabooks.org/rest/search?query=%22i+open+fire%22&expand=metadata |
@RonaldSnijder is there a specific reason for this? Would it be possible to add the ISBN ( Another field that does not seem to be present: |
@ThiloteE Hi, there are two questions here, I think:
Perhaps you can take a look here: Both issues are addressed. |
G'day! I'm a new contributor and I would like to a make an attempt at fixing this issue. I have read the developer contribution page and have setup an IntelliJ environment for local JabRef development as per the instructions. I was hoping someone could point me in the right direction as to where to begin solving the issue? Thanks! |
Hi @shafinkamal yes, you are welcome. If you look at how the other fields (e.g. |
Hi @RonaldSnijder, Thank you for your comment. I note that in an example query: https://directory.doabooks.org/rest/search?query=%22i+open+fire%22&expand=metadata,bitstreams There is no metadata relating to the ISBN within the connected Thanks, |
This commit modifies the URL for DOAB query to include `BITSTREAM` data. The fetcher can then obtain the ISBN and add the field to the entry accordingly. fixes JabRef#8708.
JabRef version
Latest development branch build (please note build date below)
Operating system
Windows
Details on version and operating system
No response
Checked with the latest development build
Steps to reproduce the behaviour
See this entry: https://directory.doabooks.org/handle/20.500.12854/35818
Search for "Accounts and Accountability in Late Medieval Europe" in JabRef DOAB websearch.
It finds:
The ISBN field is missing.
Additional info:
code can be found here: src/main/java/org/jabref/logic/importer/fetcher/DOABFetcher.java
Appendix
No response
The text was updated successfully, but these errors were encountered: