GUI: Replace "Close" by "Close library" #10043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
reviewed
Jun 27, 2023
src/main/java/org/jabref/logic/importer/fetcher/MathSciNet.java
Outdated
Show resolved
Hide resolved
Siedlerchr
reviewed
Jun 27, 2023
| @@ -70,7 +70,7 @@ public enum StandardActions implements Action { | |||
| EXPORT_SELECTED(Localization.lang("Export selected entries"), KeyBinding.EXPORT_SELECTED), | |||
| CONNECT_TO_SHARED_DB(Localization.lang("Connect to shared database"), IconTheme.JabRefIcons.CONNECT_DB), | |||
| PULL_CHANGES_FROM_SHARED_DB(Localization.lang("Pull changes from shared database"), KeyBinding.PULL_CHANGES_FROM_SHARED_DATABASE), | |||
| CLOSE_LIBRARY(Localization.lang("Close"), Localization.lang("Close the current library"), IconTheme.JabRefIcons.CLOSE, KeyBinding.CLOSE_DATABASE), | |||
| CLOSE_LIBRARY(Localization.lang("Close library"), Localization.lang("Close the current library"), IconTheme.JabRefIcons.CLOSE, KeyBinding.CLOSE_DATABASE), | |||
There was a problem hiding this comment.
you will need to fix this in en.properties as well. file https://devdocs.jabref.org/code-howtos/localization.html
There was a problem hiding this comment.
There is this one:
So I just delete this one:
?
There was a problem hiding this comment.
Add a new one with close library. I guess Close is used in other parts of the GUI as well.
Just run LocalizationConsistencyTest it will tell you
Edit// yes you can remove "Close" then
Luggas4you
force-pushed
the
Small-gui-change
branch
from
0889034 to
d143d63
Compare
|
Please add following info to the pull-request comment:
|
|
and don't forget a changelog entry :) |
calixtus
reviewed
Jun 28, 2023
CHANGELOG.md
Outdated
| @@ -26,6 +26,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve | |||
|
|
|||
| ### Changed | |||
|
|
|||
| - We replaced "Close" by "Close library" and placed it after "Save all" in the File tab. [#10043] (https://github.com/JabRef/jabref/pull/10043) | |||
There was a problem hiding this comment.
Suggested change
| - We replaced "Close" by "Close library" and placed it after "Save all" in the File tab. [#10043] (https://github.com/JabRef/jabref/pull/10043) | |
| - We replaced "Close" by "Close library" and placed it after "Save all" in the File menu. [#10043] (https://github.com/JabRef/jabref/pull/10043) |
There was a problem hiding this comment.
and no space after the []and the round ()ones
|
Applied all the suggestions. Code should be looking good now. |
koppor
approved these changes
Jul 1, 2023
calixtus
approved these changes
Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/JabRef/jabref-issue-melting-pot/issues/213
After:
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)