Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group order reset after adding a new group #10066

Merged
merged 4 commits into from
Jul 11, 2023

Conversation

aqurilla
Copy link
Contributor

@aqurilla aqurilla commented Jul 4, 2023

This fixes #10017 by removing the sort that was being carried out after group addition and edit

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@aqurilla aqurilla marked this pull request as ready for review July 4, 2023 22:30
@HoussemNasri
Copy link
Member

HoussemNasri commented Jul 9, 2023

With this PR merged, we're gonna have to reopen JabRef#577. A more sophisticated solution would be to make the sort menu item a check box item, that way when a group is added, we sort subgroups when the sort menu item is checked and keep the same order when it's not.

I think we should merge this PR because it introduces a slightly better behavior (you can sort the groups manually after adding a new group, but you can't go back to the previous order if sorting is done automatically) than the current one until we have a proper solution in place.

@HoussemNasri HoussemNasri requested a review from koppor July 9, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group order reset after adding a new group
3 participants