-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the exception when export saving order is less than 3 in export tab of preferences. #10343
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Overall looks good, just the changelog and then it's good from my side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried out locally. Works well.
Nitpick remaining ^^.
Thanks for the update! looks good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not look very beautiful, but I guess it's the correct and there is no nicer way to do this. Therefor looks 'good' to me 😄
I agree it does not look very nice. |
When saving the Preferences, if no. of items in export tab->saving order list is less than 3, exception is raised.
So in this change, it will check the no. of items in saving order list before save to corresponding prerferences attribute.
That will fix #10157
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)