-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace fetcherName with Identifier-based Web Search #10391
Conversation
@@ -154,7 +154,7 @@ public void search() { | |||
if (CompositeIdFetcher.containsValidId(query)) { | |||
CompositeIdFetcher compositeIdFetcher = new CompositeIdFetcher(preferencesService.getImportFormatPreferences()); | |||
parserResultCallable = () -> new ParserResult(OptionalUtil.toList(compositeIdFetcher.performSearchById(query))); | |||
fetcherName = compositeIdFetcher.getName(); | |||
fetcherName = "Identifier-based Web Search"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great to have this localized as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added to l10n
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self-directed learning comment: https://devdocs.jabref.org/code-howtos/localization.html
Direct comment: You forgot to put Localization.lang(...)
around. JabRef has no magic to determine translation strings.
Fixes https://github.com/JabRef/jabref-issue-melting-pot/issues/230.
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)