Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace fetcherName with Identifier-based Web Search #10391

Merged
merged 6 commits into from
Sep 22, 2023

Conversation

Luggas4you
Copy link
Contributor

@Luggas4you Luggas4you commented Sep 17, 2023

Fixes https://github.com/JabRef/jabref-issue-melting-pot/issues/230.

Screenshot 2023-09-17 172523

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@@ -154,7 +154,7 @@ public void search() {
if (CompositeIdFetcher.containsValidId(query)) {
CompositeIdFetcher compositeIdFetcher = new CompositeIdFetcher(preferencesService.getImportFormatPreferences());
parserResultCallable = () -> new ParserResult(OptionalUtil.toList(compositeIdFetcher.performSearchById(query)));
fetcherName = compositeIdFetcher.getName();
fetcherName = "Identifier-based Web Search";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to have this localized as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to l10n

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-directed learning comment: https://devdocs.jabref.org/code-howtos/localization.html

Direct comment: You forgot to put Localization.lang(...) around. JabRef has no magic to determine translation strings.

@koppor koppor enabled auto-merge September 22, 2023 08:57
@koppor koppor added this pull request to the merge queue Sep 22, 2023
Merged via the queue into JabRef:main with commit 834d527 Sep 22, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants