Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix journaltitle not showing journal info #10398

Merged
merged 4 commits into from
Sep 18, 2023
Merged

Fix journaltitle not showing journal info #10398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4bfe3a8
Fix journaltitle not showing journal info
Siedlerchr Sep 18, 2023
b2d2ee6
Add CHANGELOG.md entry
koppor Sep 18, 2023
765036a
Merge branch 'main' into fixJournalTitle
koppor Sep 18, 2023
5c3de29
Fix casing
koppor Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
- We fixed an issue where the ISBN fetcher returned the entrytype `misc` for certain ISBN numbers [#10348](https://github.com/JabRef/jabref/issues/10348)
- We fixed a bug where an exception was raised when saving less than three export save orders in the preference. [#10157](https://github.com/JabRef/jabref/issues/10157)
- We fixed an issue where it was possible to create a group with no name or with a group separator inside the name [#9776](https://github.com/JabRef/jabref/issues/9776)
- Biblatex's `journaltitle` is now also respected for showing the journal information. [#10397](https://github.com/JabRef/jabref/issues/10397)
- JabRef does not hang anymore when exporting via CLI. [#10380](https://github.com/JabRef/jabref/issues/10380)

### Removed
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/jabref/gui/fieldeditors/PopOverUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public class PopOverUtil {

public static void showJournalInfo(Button button, BibEntry entry, DialogService dialogService, TaskExecutor taskExecutor) {
Optional<String> optionalIssn = entry.getField(StandardField.ISSN);
Optional<String> optionalJournalName = entry.getField(StandardField.JOURNAL);
Optional<String> optionalJournalName = entry.getFieldOrAlias(StandardField.JOURNAL);

if (optionalIssn.isPresent() || optionalJournalName.isPresent()) {
PopOver popOver = new PopOver();
Expand Down