Infer DOI from ArXiv identifier #10449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
reviewed
Oct 5, 2023
|
|
||
| if (doi.isPresent()) { | ||
| // Update Doi | ||
| Optional<FieldChange> change = entry.setField(StandardField.DOI, doi.get().getDOI()); | ||
| change.ifPresent(changes::add); | ||
| removeFieldValue(entry, field, changes); | ||
| } | ||
|
|
||
| if (StandardField.EPRINT == field && fieldContentOpt.isPresent()) { |
There was a problem hiding this comment.
I think the isPresent check for fieldContentOPt is not necessary here as it's already covered by the ifPresent
There was a problem hiding this comment.
Nice catch, it's removed now.
Siedlerchr
approved these changes
Oct 5, 2023
Siedlerchr
added a commit
that referenced
this pull request
Oct 8, 2023
…in-protected-terms-files * upstream/main: Update src/main/java/org/jabref/logic/exporter/AtomicFileOutputStream.java Fix saving on network drive under macOS Infer DOI from ArXiv identifier (#10449) Add TexShop Icon (#10447) Fix PDF export (#10361) Fixed SpringerFetcherTest and ACMPortalFetcherTest (#10445) Bump org.openrewrite.rewrite from 6.3.11 to 6.3.16 (#10442) Update all of lucene Bump org.apache.lucene:lucene-core from 9.7.0 to 9.8.0 Bump com.dlsc.gemsfx:gemsfx from 1.77.0 to 1.82.0 Accept LaTeX errors in comment field (#10436) fix checkstyle fix escaping of slashes fix checkstyle and l10n Add TeXShop (macOS only)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10426
Adding to the DOI cleanup action: If an entry has an eprint field that contains an ArXiv ID, infer the DOI field.
The infer logic is based on this article: https://blog.arxiv.org/2022/02/17/new-arxiv-articles-are-now-automatically-assigned-dois/
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)