Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark download PDF test as fetcher test #10457

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Mark download PDF test as fetcher test #10457

merged 1 commit into from
Oct 7, 2023

Conversation

Siedlerchr
Copy link
Member

Sometimes fails on CI

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 7, 2023
@Siedlerchr Siedlerchr enabled auto-merge October 7, 2023 09:40
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@Siedlerchr Siedlerchr added this pull request to the merge queue Oct 7, 2023
Merged via the queue into main with commit 71a1ccc Oct 7, 2023
14 checks passed
@Siedlerchr Siedlerchr deleted the markTestAsFetcherTest branch October 7, 2023 21:18
Siedlerchr added a commit that referenced this pull request Oct 8, 2023
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix/ui-improvement-…
630d7c1 
…in-protected-terms-files

* upstream/main:
  Simplify code (#10460)
  Mark download PDF test as fetcher test (#10457)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koppor koppor koppor approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Siedlerchr @koppor