Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow up to crossref issue and number #10481

Merged
merged 1 commit into from
Oct 12, 2023
Merged

follow up to crossref issue and number #10481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/jabref/logic/importer/fetcher/CrossRef.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ private BibEntry jsonItemToBibEntry(JSONObject item) throws ParseException {
entry.setField(StandardField.DOI, item.getString("DOI"));
entry.setField(StandardField.JOURNAL, item.optString("container-title"));
entry.setField(StandardField.PUBLISHER, item.optString("publisher"));
entry.setField(StandardField.ISSUE, item.optString("issue"));
entry.setField(StandardField.NUMBER, item.optString("issue"));
entry.setField(StandardField.KEYWORDS, Optional.ofNullable(item.optJSONArray("subject")).map(this::getKeywords).orElse(""));
entry.setField(StandardField.PAGES, item.optString("page"));
entry.setField(StandardField.VOLUME, item.optString("volume"));
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/jabref/logic/importer/fetcher/CrossRefTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ public void performSearchByIdFindsPaperWithoutTitle() throws Exception {
entry.setField(StandardField.VOLUME, "42");
entry.setField(StandardField.YEAR, "1999");
entry.setField(StandardField.JOURNAL, "Indo-Iranian Journal");
entry.setField(StandardField.ISSUE, "2");
entry.setField(StandardField.NUMBER, "2");
entry.setField(StandardField.PUBLISHER, "Brill");
entry.setField(StandardField.KEYWORDS, "Political Science and International Relations, Linguistics and Language, Philosophy");

Expand Down
Loading