Add export of com.sun.javafx.event to org.jabref #11195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"Brute force" adding to many places also does not help: diff --git a/build.gradle b/build.gradle
index 553a0c29da..9667908ebc 100644
--- a/build.gradle
+++ b/build.gradle
@@ -394,7 +394,9 @@ compileJava {
// TODO: Remove access to internal api
addExports = [
// Fix for https://github.com/JabRef/jabref/issues/11188
+ 'javafx.base/com.sun.javafx.event' : 'org.controlsfx.controls',
'javafx.base/com.sun.javafx.event' : 'org.jabref',
+ 'javafx.base/com.sun.javafx.event' : 'org.jabref.merged.module',
'javafx.controls/com.sun.javafx.scene.control' : 'org.jabref',
'org.controlsfx.controls/impl.org.controlsfx.skin' : 'org.jabref'
@@ -406,6 +408,7 @@ run {
// TODO: Remove access to internal api
moduleOptions {
addExports = [
+ 'javafx.base/com.sun.javafx.event' : 'org.jabref',
'javafx.controls/com.sun.javafx.scene.control' : 'org.jabref',
'org.controlsfx.controls/impl.org.controlsfx.skin' : 'org.jabref',
@@ -424,6 +427,7 @@ run {
]
addOpens = [
+ 'javafx.base/com.sun.javafx.event' : 'org.jabref',
'javafx.controls/javafx.scene.control' : 'org.jabref',
'org.controlsfx.controls/org.controlsfx.control.textfield' : 'org.jabref',
'javafx.controls/com.sun.javafx.scene.control' : 'org.jabref', |
|
The exception in line wrapped form:
|
|
needs to be added to the run below as well |
You mean the |
|
The secret was to use |
koppor
changed the title
koppor
added
the
status: ready-for-review
2 tasks
Siedlerchr
reviewed
Apr 15, 2024
build.gradle
Outdated
|
|
||
| applicationDefaultJvmArgs = | ||
| // Fix for https://github.com/JabRef/jabref/issues/11188 | ||
| ['--add-exports=javafx.base/com.sun.javafx.event=org.jabref.merged.module'] |
There was a problem hiding this comment.
seems like we need to add all runStuff here
'> java.lang.reflect.InaccessibleObjectException: Unable to make protected javafx.collections.ObservableList javafx.scene.Parent.getChildren() accessible: module javafx.graphics does not "opens javafx.scene" to module org.jabref.merged.module
from #11198
|
And we seem to need more?! |
|
Last commit was because of |
|
Current issue - when buld locally, it works, when build on the CI, it does not work. |
Siedlerchr
previously approved these changes
Apr 15, 2024
calixtus
approved these changes
Apr 15, 2024
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
|
Unable to compile on windows after this PR. Log |
|
@LoayGhreeb I got it, too. Should be fixed at #11208. Please check latest main :) |
|
yes, it's fixed. Although those "WARNING" messages are still showing up, but I think it's fine. |
6 tasks
I filed #11209 to avoid the messages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently does not fix the issue (tried out locally using jPackage).
I have no clue how to continue.
It is also not about
forceMerge, because the issue reporter says he used the release version (where our update of #11170) is not included.Idea from sshahine/JFoenix#1133 (comment)
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)