Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-11102 by giving user option to add a bst style preview to available #11229

Closed
wants to merge 3 commits into from

Conversation

sahilsekr42
Copy link
Contributor

I've tried to fix #11102 by adding a button which may be used to add the selected bst files to the available styles and tested it to work although I think for preview to function well bstvm should be used not sure how. Would like some guidence . After it works as expected may be documentation can be modified.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr
Copy link
Member

You can click on the details next to the failing test and you will see where the error is.

@subhramit
Copy link
Member

subhramit commented Apr 21, 2024

To conform to JabRef's Checkstyle, set up the following:
https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace/intellij-13-code-style.html

To pass the OpenRewrite check, run gradle rewriteRun.
Info: https://docs.openrewrite.org/

@subhramit
Copy link
Member

subhramit commented Apr 21, 2024

Your unit test error log says:

Task :compileJava
/home/runner/work/jabref/jabref/src/main/java/org/jabref/gui/preferences/preview/PreviewTab.java:123: error: cannot find symbol
        previewViewer.setEntry(TestEntry.getTestEntry());
        ^
  symbol:   variable previewViewer
  location: class PreviewTab

You're probably using an undeclared symbol.

(To check, click on "Details").

@subhramit
Copy link
Member

subhramit commented Apr 21, 2024

Also, add a changelog line.
Refer https://devdocs.jabref.org/contributing.html (Formal requirements for a pull request).

@subhramit
Copy link
Member

subhramit commented Apr 21, 2024

Hey, may I know why you closed the PR?
By the way, thanks for moving forward. I know, the first PR can be overwhelming, but this will get you used to all the formalities and you won't face much difficulties afterwards.
I also suggest you join the Gitter chat where you can ask miscellaneous queries.

@sahilsekr42
Copy link
Contributor Author

okay , i,m joining btw i closed it because of my poor understanding of how pull requests and automated tests work ( glad to learn now )

@subhramit
Copy link
Member

okay , i,m joining btw i closed it because of my poor understanding of how pull requests and automated tests work ( glad to learn now )

No issues at all, ask as many questions as you want. We'll be there to help.

@koppor
Copy link
Member

koppor commented Apr 21, 2024

@sahilsekr42 You can reopen the PR by clicking on "Reopen", can't you?

@koppor
Copy link
Member

koppor commented Apr 21, 2024

Ah, follow-up PR is #11234.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the option to select a BST style for Preview
4 participants