-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix-11102 by giving user option to add a bst style preview to available #11229
Conversation
You can click on the details next to the failing test and you will see where the error is. |
To conform to JabRef's Checkstyle, set up the following: To pass the OpenRewrite check, run |
Your unit test error log says:
You're probably using an undeclared symbol. (To check, click on "Details"). |
Also, add a changelog line. |
Hey, may I know why you closed the PR? |
okay , i,m joining btw i closed it because of my poor understanding of how pull requests and automated tests work ( glad to learn now ) |
No issues at all, ask as many questions as you want. We'll be there to help. |
@sahilsekr42 You can reopen the PR by clicking on "Reopen", can't you? |
Ah, follow-up PR is #11234. |
I've tried to fix #11102 by adding a button which may be used to add the selected bst files to the available styles and tested it to work although I think for preview to function well bstvm should be used not sure how. Would like some guidence . After it works as expected may be documentation can be modified.
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)