Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-Focus Group on Creation #11453

Merged
merged 6 commits into from
Jul 9, 2024
Merged

Auto-Focus Group on Creation #11453

merged 6 commits into from
Jul 9, 2024

Conversation

m-peeler
Copy link
Contributor

@m-peeler m-peeler commented Jul 5, 2024

When a new group is created, it is automatically focused in the viewer. This addresses and closes #11449.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

m-peeler added 2 commits July 5, 2024 02:58
@m-peeler
Auto-Select Newly Created Group
910c857 
When a new group is added, that group will automatically be selected and focused.
@m-peeler
Update CHANGELOG.md
cbc0d7d 
Updated changelog to reflect updates.
koppor
koppor requested changes Jul 5, 2024
View reviewed changes
Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides minor comments, LGTM 👍. The changes need a second review and thus this PR awaits a second review.

CHANGELOG.md Outdated Show resolved Hide resolved
@m-peeler @koppor
Update CHANGELOG.md
f80751a 
Fixed capitalization in changelog

Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
@koppor koppor added this to the 6.0-alpha milestone Jul 5, 2024
@koppor
Copy link
Member

koppor commented Jul 5, 2024

Due to the discussion at #11449 postponed to 6.0-alpha

@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jul 5, 2024
@m-peeler @LoayGhreeb
Update src/main/java/org/jabref/gui/StateManager.java
3e6579f 
Co-authored-by: Loay Ghreeb <52158423+LoayGhreeb@users.noreply.github.com>
LoayGhreeb
LoayGhreeb previously approved these changes Jul 5, 2024
View reviewed changes
@koppor
Copy link
Member

koppor commented Jul 9, 2024

@m-peeler I needed to merge main and update CHANGELOG.md, because we had a release meanwhile. And due to the discussion at the issue, I did not dare to distribute that functionality in a release.

@koppor koppor enabled auto-merge July 9, 2024 07:14
@koppor koppor added this pull request to the merge queue Jul 9, 2024
Merged via the queue into JabRef:main with commit cb1f00f Jul 9, 2024
21 checks passed
@m-peeler m-peeler mentioned this pull request Jul 9, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koppor koppor koppor approved these changes

@LoayGhreeb LoayGhreeb LoayGhreeb left review comments

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
6.0-alpha
Development

Successfully merging this pull request may close these issues.

After creation of a group, the group should be focused
3 participants
@m-peeler @koppor @LoayGhreeb