Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix moving of file into library #12001

Merged
merged 35 commits into from
Oct 23, 2024
Merged

Fix moving of file into library #12001

merged 35 commits into from
Oct 23, 2024

Conversation

koppor
Copy link
Member

@koppor koppor commented Oct 16, 2024

Fixes https://github.com/JabRef/jabref-issue-melting-pot/issues/630

Follow-up to #11576

Additionally:

  • We added support for modifier keys when dropping a file on an entry in the main table.
  • When dropping a file into the main table, after copy or move, the file is now renamed according to the configured patterns.

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr
Copy link
Member

Need to test under Mac, there was something about modifiers not working

@koppor
Copy link
Member Author

koppor commented Oct 17, 2024

Need to test under Mac, there was something about modifiers not working

Test is drag and drop with and without modifier keys>

  • outside file directory
  • inside file directory

Which means: 6 different manual test cases.

You can also add drag'n'drop from another volume, which makes then 9 test cases.

@github-actions GitHub Actions
Copy link
Contributor

The build of this PR is available at https://builds.jabref.org/pull/12001/merge.

@github-actions GitHub Actions
Copy link
Contributor

The build of this PR is available at https://builds.jabref.org/pull/12001/merge.

@github-actions GitHub Actions
Copy link
Contributor

The build of this PR is available at https://builds.jabref.org/pull/12001/merge.

@github-actions GitHub Actions
Copy link
Contributor

The build of this PR is available at https://builds.jabref.org/pull/12001/merge.

@BaronMac08 BaronMac08 mentioned this pull request Oct 20, 2024
Closed
7 tasks
@Siedlerchr
Copy link
Member

Mac only supports copy https://bugs.openjdk.org/browse/JDK-8264172

github-actions[bot]

This comment was marked as outdated.

Sign in to view

@InAnYan
Copy link
Collaborator

InAnYan commented Oct 23, 2024 •
edited
Loading

I've only done 3 test cases with a .bib file outside of the PDFs files directory.

The PR works!

(Linux Mint)

@koppor
Copy link
Member Author

koppor commented Oct 23, 2024

One needs to check whether the file indexing works - or causes trouble... I would bet it works, because I first handle the file on the file system and then add it to jabref which then indexes it...

@koppor
Merge remote-tracking branch 'origin/main' into fix-melting-630
a64c4d8 
# Conflicts:
#	src/main/java/org/jabref/gui/entryeditor/EntryEditor.java
#	src/main/java/org/jabref/gui/externalfiles/ExternalFilesEntryLinker.java
#	src/main/java/org/jabref/gui/maintable/MainTable.java
#	src/main/java/org/jabref/gui/preview/PreviewPanel.java
github-actions[bot]
github-actions bot reviewed Oct 23, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.

You can check review dog's comments at the tab "Files changed" of your pull request.

@LoayGhreeb
Copy link
Member

Fixed compilation errors, removed IndexManager from ImportHandler, and removed the index blocker.
Tested, the indexing works without issues.

github-actions[bot]

This comment was marked as resolved.

Sign in to view

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor
Copy link
Member Author

koppor commented Oct 23, 2024

@LoayGhreeb Thank you for fixing! Then we can go ahead!

@koppor koppor added the automerge PR is tagged with that label will be merged if workflows are green label Oct 23, 2024
@koppor koppor added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit 650d4a2 Oct 23, 2024
27 checks passed
@koppor koppor deleted the fix-melting-630 branch October 23, 2024 15:48
This was referenced Oct 23, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Siedlerchr Siedlerchr Siedlerchr left review comments

@jabref-machine jabref-machine jabref-machine approved these changes

Assignees
No one assigned
Labels
automerge PR is tagged with that label will be merged if workflows are green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@koppor @Siedlerchr @InAnYan @LoayGhreeb @jabref-machine