Some OO/LO cleanups #1927
Merged
Some OO/LO cleanups #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscargus
added
status: ready-for-review
| @@ -1366,13 +1366,13 @@ public BibDatabase generateDatabase(List<BibDatabase> databases) | |||
| BibEntry clonedEntry = (BibEntry) entry.get().clone(); | |||
| clonedEntry.setId(IdGenerator.next()); | |||
| // Insert a copy of the entry | |||
| resultDatabase.insertEntryWithDuplicationCheck(clonedEntry); | |||
| resultDatabase.insertEntry(clonedEntry); | |||
There was a problem hiding this comment.
Just wondering: Is it save to remove the duplication check here? The documentation of insertEntryWithDuplicationCheck says use insertEntry and DuplicationChecker separately.
The comment also applies to the replacement below.
|
Apart from the clarification above: LGTM! |
|
Well the duplication check just returns a boolean and as that is not checked here it shouldn't make any functional difference. If it was a good idea in the first place is another question though... |
|
LGTM 👍 |
Siedlerchr
added a commit
that referenced
this pull request
Sep 11, 2016
* master: Remove obsolete wrapper task Added error dialog when setting invalid main file directory (#1921) Add filteringCharset = 'UTF-8' (#1945) Include https://github.com/grimes2 Searchbar across all bib files instead each having its own (#1549) Some OO/LO cleanups (#1927) Update link Removed external dependency in logic (#1934)
Siedlerchr
added a commit
to Siedlerchr/jabref
that referenced
this pull request
Sep 11, 2016
* master: Remove obsolete wrapper task Added error dialog when setting invalid main file directory (JabRef#1921) Add filteringCharset = 'UTF-8' (JabRef#1945) Include https://github.com/grimes2 Searchbar across all bib files instead each having its own (JabRef#1549) Some OO/LO cleanups (JabRef#1927) Update link Removed external dependency in logic (JabRef#1934)
zesaro
pushed a commit
to zesaro/jabref
that referenced
this pull request
Nov 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed deprecated calls, renamed a few variables, and restructured the code a bit.