Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Integrate BibSonomy Plugin #2157

Closed
wants to merge 63 commits into from
Closed

Conversation

zesaro
Copy link
Contributor

@zesaro zesaro commented Oct 12, 2016

We try to offer the latest build at http://builds.jabref.org/bibsonomy/. Feel free to comment on the functionality in this PR.

BibSonomy is a tool for maintaining references. PUMA is the instance of the University of Stuttgart. For more information, check the related work of CloudRef.

Example usage of BibSonomy:

grafik

Aim: Get first working version into JabRef again, do some marketing, and attract a maintainer for that functionality.

The aim of this pull request is to integrate the BibSonomy Plugin from JabRef 2.11 into the actual JabRef master branch. You can run BibSonomy from the menubar (between Tools and Options), search for entries and fetch them. There are still parts in the code which has to be updated. Since 2.11 much has changed. For example the MetaData which I have to investigate.

I am looking forward to hear your feedback.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • If you changed the localization: Did you run gradle localizationUpdate?

Notes

  • BibSonomy seems to use following fields: interhash;intrahash;keywords;groups;privnote. Special handling for them is removed in this PR as it is unclear how they are used.

@zesaro zesaro force-pushed the bibsonomy branch 2 times, most recently from 42694cc to e415619 Compare October 15, 2016 16:53
@tobiasdiez
Copy link
Member

Does it make sense to integrate the "Search BibSononym" feature as a fetcher?

@koppor
Copy link
Member

koppor commented Oct 16, 2016

Here a screenshot:

grabbed_20160928-231813

@koppor koppor added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Oct 24, 2016
@lenhard
Copy link
Member

lenhard commented Nov 18, 2016

What is the status / plan here? I am not quite sure as to what questions are waiting for being answered here?

The size of the PR is a little scary. 5000+ lines are well above what we can meaningfully review.

@koppor
Copy link
Member

koppor commented Nov 18, 2016

@zellerdev is going to provide an update on Tuesday. The size of the code cannot be reduced easily, because we include a plugin, which is large by itself.

See f8da659 and https://bitbucket.org/bibsonomy/bibsonomy-jabref-plugin/wiki/Home

This PR is a huge step to fix #152

@zesaro zesaro force-pushed the bibsonomy branch 2 times, most recently from 3a43cdf to 3e4c203 Compare November 22, 2016 00:53
@koppor koppor removed the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Dec 16, 2016
# Conflicts:
#	src/main/java/net/sf/jabref/model/metadata/MetaData.java
@koppor
Copy link
Member

koppor commented Dec 19, 2016

Status: Functionality works. Also with PUMA. Others should test it, too.

Open issues:

  • Code refactoring
  • Tests
  • Check whether the handling of Metadata is correct

koppor added 6 commits May 11, 2018 08:58
# Conflicts:
#	build.gradle
#	external-libraries.txt
#	src/main/java/org/jabref/gui/IconTheme.java
#	src/main/java/org/jabref/gui/JabRefFrame.java
#	src/main/java/org/jabref/gui/preftabs/FontSelectorDialog.java
#	src/main/java/org/jabref/model/strings/StringUtil.java
#	src/main/resources/l10n/JabRef_da.properties
#	src/main/resources/l10n/JabRef_de.properties
#	src/main/resources/l10n/JabRef_en.properties
#	src/main/resources/l10n/JabRef_es.properties
#	src/main/resources/l10n/JabRef_fa.properties
#	src/main/resources/l10n/JabRef_fr.properties
#	src/main/resources/l10n/JabRef_in.properties
#	src/main/resources/l10n/JabRef_it.properties
#	src/main/resources/l10n/JabRef_ja.properties
#	src/main/resources/l10n/JabRef_nl.properties
#	src/main/resources/l10n/JabRef_no.properties
#	src/main/resources/l10n/JabRef_pt_BR.properties
#	src/main/resources/l10n/JabRef_ru.properties
#	src/main/resources/l10n/JabRef_sv.properties
#	src/main/resources/l10n/JabRef_tr.properties
#	src/main/resources/l10n/JabRef_vi.properties
#	src/main/resources/l10n/JabRef_zh.properties
#	src/test/java/org/jabref/logic/formatter/FormatterTest.java
@koppor koppor reopened this May 31, 2018
@koppor koppor removed the freeze label May 31, 2018
@koppor
Copy link
Member

koppor commented May 31, 2018

@tobiasdiez
Copy link
Member

Maybe @halirutan can add the cancel icon to our own font (or we just choose a different icon for the time being...)

@halirutan
Copy link
Collaborator

@koppor @tobiasdiez Here #4069

@tobiasdiez
Copy link
Member

@halirutan perfect! Thanks.
@koppor now you need to base on the maintable branch ;-)

@koppor koppor mentioned this pull request Jun 3, 2018
@tobiasdiez
Copy link
Member

Any update? I'll mark this as on-hold for the moment. Feel free to merge the latest master, update the code and reopen.

@koppor
Copy link
Member

koppor commented Oct 10, 2018

I am not able to code JavaFX, so we really need help from the community. Maybe @zesaro wants to learn JavaFX and bring JabRef a huge step forward!

@zesaro
Copy link
Contributor Author

zesaro commented Oct 14, 2018

I am always interested in learning new things. Currently I'm not up to date with this PR. Is this meant to update this PR or address issues in the Rework?
But it eventually would be a slow process. What about the JavaFX Team from @JabRef/stupro ? 😄

@zesaro
Copy link
Contributor Author

zesaro commented Mar 13, 2019

Is this still relevant? What has to be done here? Something with JavaFX?
I'd love to finish what I started 😅

@koppor
Copy link
Member

koppor commented Mar 13, 2019 via email

@zesaro
Copy link
Contributor Author

zesaro commented Jun 3, 2020

Is the bibsonomy-rest-client still usable with the current version of JabRef? I didn't work with Java for a long time now and never touched the new modules.
But I was curious. So I checked out a new branch from the current master and updated build.gradle to use the dependencies for the current bibsonomy-rest-client (3.9.2). Basically a two-liner.
But this seems to bite with some modules. At least I can't execute the run command successfully anymore.
Amy I missing something?

@zesaro zesaro deleted the bibsonomy branch January 16, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants