Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize previe before MainPanel to prevent NPEs on delete #3588

Merged
merged 1 commit into from
Dec 29, 2017

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Dec 29, 2017

Fixes #3584

(No changelod needed as this is a followup from #3574


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 29, 2017
@tobiasdiez
Copy link
Member

Thanks for the fix. I'll merge directly since this is only a minor change.

@tobiasdiez tobiasdiez merged commit 7a578de into master Dec 29, 2017
@tobiasdiez tobiasdiez deleted the fixBasePanelNpeOnDelete branch December 29, 2017 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants