Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix style issues in about dialog #4245

Merged
merged 7 commits into from
Aug 10, 2018
Merged

Fix style issues in about dialog #4245

merged 7 commits into from
Aug 10, 2018

Conversation

tobiasdiez
Copy link
Member

Fixes #4202 and a few other small style related issues. I also created a little new app that make it simple to test the display of JavaFX controls. As of now, I only added a lot of buttons in different styles and states:
image

Please merge instead of squashing the commits.


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 1, 2018
@Siedlerchr
Copy link
Member

Lgtm

@Siedlerchr
Copy link
Member

I am merging this now

@Siedlerchr Siedlerchr merged commit ce0e3b1 into master Aug 10, 2018
@tobiasdiez tobiasdiez deleted the fixStyle branch August 10, 2018 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants