Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uncaught exception message #4565

Merged
merged 4 commits into from
Jan 5, 2019
Merged

Add uncaught exception message #4565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bdefa6b
Add error message for uncaught exceptions
Le-wi Jan 1, 2019
c492ad2
Add simple text to fallback error view
Le-wi Jan 2, 2019
4c696a8
Add error message to language files
Le-wi Jan 3, 2019
424e61d
Add ErrorDialogAndWait
Le-wi Jan 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `#
- We fixed an issue where only one PDF file could be imported [#4422](https://github.com/JabRef/jabref/issues/4422)
- We fixed an issue where "Move to group" would always move the first entry in the library and not the selected [#4414](https://github.com/JabRef/jabref/issues/4414)
- We fixed an issue where an older dialog appears when downloading full texts from the quality menu. [#4489](https://github.com/JabRef/jabref/issues/4489)

- We fixed an issue where uncaught exceptions were logged but the user wasn't informed about their occurance. [#2288] (https://github.com/JabRef/jabref/issues/2288)



Expand Down
4 changes: 4 additions & 0 deletions src/main/java/org/jabref/FallbackExceptionHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,9 @@ public static void installExceptionHandler() {
@Override
public void uncaughtException(Thread thread, Throwable exception) {
LOGGER.error("Uncaught exception occurred in " + thread, exception);
JabRefGUI.getMainFrame()
.getDialogService()
.showErrorDialogAndWait(
exception.getLocalizedMessage(), exception);
}
}
3 changes: 0 additions & 3 deletions src/main/resources/l10n/JabRef_de.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2200,6 +2200,3 @@ Website=Webseite
Write\ XMP-metadata\ to\ PDFs=&XMP-Metadaten in PDFs schreiben

Override\ default\ font\ settings=Standardschrifteinstellungen überschreiben



2 changes: 1 addition & 1 deletion src/main/resources/l10n/JabRef_en.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2244,4 +2244,4 @@ Main\ layout\ file\:=Main layout file\:
Main\ layout\ file=Main layout file
Save\ exporter=Save exporter
File\ extension\:=File extension\:
Export\ format\ name\:=Export format name\:
Export\ format\ name\:=Export format name\: