-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove obsolete swing components in Preferences and OpenOffice #4740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Siedlerchr
commented
Mar 9, 2019
•
edited
Loading
edited
- Change in CHANGELOG.md described
- Tests created for changes
- Manually tested changed features in running JabRef
- Screenshots added in PR description (for bigger UI changes)
- Ensured that the git commit message is a good one
- Check documentation status (Issue created for outdated help page at help.jabref.org?)
tobiasdiez
requested changes
Mar 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Code looks mostly good to me, only one thing concerning the background task should be changed.
* upstream/master: Revert "Revert "Fix: bibkey generated does not handle diacritics" (#4741)" (#4742) Revert "Fix: bibkey generated does not handle diacritics" (#4741) Rename method to removeUnwantedCharacters Remove the dashes from test case Remove -s from key Update test cases Filter unwanted characters before removing whitespaces Fix NotOnJavaFXThread exception for remote import Remove old swing-based tests Extract authN method Shift cleaning of authString to authN only Clean key in BracketedPattern after author value is retrieved
* upstream/master: Move library specific key pattern dialog call to library menu (#4744)
set title of choice dialog
Siedlerchr
added a commit
that referenced
this pull request
Mar 16, 2019
…erbibtexkey * upstream/master: (827 commits) [#4306] Disable renaming (#4727) Feature: implement search filter in show preferences (#4759) Enable import button only if entry selected (#4761) Improve Remote messaging (#4760) Add changelog entry for #4520 Modifications to improve contrast of UI elements (#4758) Rework external changes dialog in JavaFX (#4693) Changes the title of Group Dialog to Add subgroup when adding a new subgroup (#4757) Optimize data fetching (#4520) Adds a browse button next to the path text field for aux-based groups (#4743) Saving changes and exiting application (#4729) Code optimized and created a reusable method to get writer output (#4750) Bump mvvmfx from 1.7.0 to 1.8.0 (#4747) Bump guava from 27.0.1-jre to 27.1-jre (#4748) Bump mvvmfx-validation from 1.7.0 to 1.8.0 (#4749) Remove obsolete swing components in Preferences and OpenOffice (#4740) Move library specific key pattern dialog call to library menu (#4744) Revert "Revert "Fix: bibkey generated does not handle diacritics" (#4741)" (#4742) Revert "Fix: bibkey generated does not handle diacritics" (#4741) Rename method to removeUnwantedCharacters ...
github-actions bot
pushed a commit
to dextep/jabref
that referenced
this pull request
May 3, 2020
1e20dbd Harvard Stellenbosch: Further et al adjustment a59a17e Update american-medical-association.csl to version 11 (JabRef#4727) 22849dd Create unified-style-sheet-for-linguistics-de-gruyter-literature.csl (JabRef#4627) 647fb56 Update karabuk-university-graduate-school-of-natural-and-applied-scie… (JabRef#4756) a4317f2 Update quaternaire.csl (JabRef#4752) 36fe9c2 Update journal-of-management-studies.csl (JabRef#4740) f0cb15d Bugfix (JabRef#4750) ef19002 Revert 1 yrg23 patch 1 (JabRef#4754) 873fc9e Update the-geological-society-of-london.csl (JabRef#4738) 93ca354 Update The Geological Society dependents (JabRef#4751) 9d3f0f5 Update technische-universitat-dresden-linguistik.csl (JabRef#4737) 63d657c change et al. min (JabRef#4736) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 1e20dbd
github-actions bot
pushed a commit
to dimitra-karadima/jabref
that referenced
this pull request
May 5, 2020
cb19d25 Create revista-biblica.csl (JabRef#4763) d40b5ff Small corrections in IFAO style (JabRef#4761) ba4dd7c Add NZ Journal of History (JabRef#4760) 1e20dbd Harvard Stellenbosch: Further et al adjustment a59a17e Update american-medical-association.csl to version 11 (JabRef#4727) 22849dd Create unified-style-sheet-for-linguistics-de-gruyter-literature.csl (JabRef#4627) 647fb56 Update karabuk-university-graduate-school-of-natural-and-applied-scie… (JabRef#4756) a4317f2 Update quaternaire.csl (JabRef#4752) 36fe9c2 Update journal-of-management-studies.csl (JabRef#4740) f0cb15d Bugfix (JabRef#4750) ef19002 Revert 1 yrg23 patch 1 (JabRef#4754) 873fc9e Update the-geological-society-of-london.csl (JabRef#4738) 93ca354 Update The Geological Society dependents (JabRef#4751) 9d3f0f5 Update technische-universitat-dresden-linguistik.csl (JabRef#4737) 63d657c change et al. min (JabRef#4736) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: cb19d25
dimitra-karadima
pushed a commit
to dimitra-karadima/jabref
that referenced
this pull request
May 6, 2020
cb19d25 Create revista-biblica.csl (JabRef#4763) d40b5ff Small corrections in IFAO style (JabRef#4761) ba4dd7c Add NZ Journal of History (JabRef#4760) 1e20dbd Harvard Stellenbosch: Further et al adjustment a59a17e Update american-medical-association.csl to version 11 (JabRef#4727) 22849dd Create unified-style-sheet-for-linguistics-de-gruyter-literature.csl (JabRef#4627) 647fb56 Update karabuk-university-graduate-school-of-natural-and-applied-scie… (JabRef#4756) a4317f2 Update quaternaire.csl (JabRef#4752) 36fe9c2 Update journal-of-management-studies.csl (JabRef#4740) f0cb15d Bugfix (JabRef#4750) ef19002 Revert 1 yrg23 patch 1 (JabRef#4754) 873fc9e Update the-geological-society-of-london.csl (JabRef#4738) 93ca354 Update The Geological Society dependents (JabRef#4751) 9d3f0f5 Update technische-universitat-dresden-linguistik.csl (JabRef#4737) 63d657c change et al. min (JabRef#4736) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: cb19d25
github-actions bot
pushed a commit
to leitianjian/jabref
that referenced
this pull request
May 7, 2020
270cd32 small fixes for revista-biblica.csl (JabRef#4770) 5dd7ede fix issue with DOI URL for unified-style-sheet-for-linguistics.csl (JabRef#4765) 9556b12 Create the-american-journal-of-bioethics.csl (JabRef#4766) d50c761 fix initials of revista-biblica.csl (JabRef#4768) acbb043 Create nwu-harvard-2020.csl (JabRef#4762) cb19d25 Create revista-biblica.csl (JabRef#4763) d40b5ff Small corrections in IFAO style (JabRef#4761) ba4dd7c Add NZ Journal of History (JabRef#4760) 1e20dbd Harvard Stellenbosch: Further et al adjustment a59a17e Update american-medical-association.csl to version 11 (JabRef#4727) 22849dd Create unified-style-sheet-for-linguistics-de-gruyter-literature.csl (JabRef#4627) 647fb56 Update karabuk-university-graduate-school-of-natural-and-applied-scie… (JabRef#4756) a4317f2 Update quaternaire.csl (JabRef#4752) 36fe9c2 Update journal-of-management-studies.csl (JabRef#4740) f0cb15d Bugfix (JabRef#4750) ef19002 Revert 1 yrg23 patch 1 (JabRef#4754) 873fc9e Update the-geological-society-of-london.csl (JabRef#4738) 93ca354 Update The Geological Society dependents (JabRef#4751) 9d3f0f5 Update technische-universitat-dresden-linguistik.csl (JabRef#4737) 63d657c change et al. min (JabRef#4736) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 270cd32
github-actions bot
pushed a commit
that referenced
this pull request
May 7, 2020
270cd32 small fixes for revista-biblica.csl (#4770) 5dd7ede fix issue with DOI URL for unified-style-sheet-for-linguistics.csl (#4765) 9556b12 Create the-american-journal-of-bioethics.csl (#4766) d50c761 fix initials of revista-biblica.csl (#4768) acbb043 Create nwu-harvard-2020.csl (#4762) cb19d25 Create revista-biblica.csl (#4763) d40b5ff Small corrections in IFAO style (#4761) ba4dd7c Add NZ Journal of History (#4760) 1e20dbd Harvard Stellenbosch: Further et al adjustment a59a17e Update american-medical-association.csl to version 11 (#4727) 22849dd Create unified-style-sheet-for-linguistics-de-gruyter-literature.csl (#4627) 647fb56 Update karabuk-university-graduate-school-of-natural-and-applied-scie… (#4756) a4317f2 Update quaternaire.csl (#4752) 36fe9c2 Update journal-of-management-studies.csl (#4740) f0cb15d Bugfix (#4750) ef19002 Revert 1 yrg23 patch 1 (#4754) 873fc9e Update the-geological-society-of-london.csl (#4738) 93ca354 Update The Geological Society dependents (#4751) 9d3f0f5 Update technische-universitat-dresden-linguistik.csl (#4737) 63d657c change et al. min (#4736) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 270cd32
dextep
pushed a commit
to dextep/jabref
that referenced
this pull request
May 8, 2020
1e20dbd Harvard Stellenbosch: Further et al adjustment a59a17e Update american-medical-association.csl to version 11 (JabRef#4727) 22849dd Create unified-style-sheet-for-linguistics-de-gruyter-literature.csl (JabRef#4627) 647fb56 Update karabuk-university-graduate-school-of-natural-and-applied-scie… (JabRef#4756) a4317f2 Update quaternaire.csl (JabRef#4752) 36fe9c2 Update journal-of-management-studies.csl (JabRef#4740) f0cb15d Bugfix (JabRef#4750) ef19002 Revert 1 yrg23 patch 1 (JabRef#4754) 873fc9e Update the-geological-society-of-london.csl (JabRef#4738) 93ca354 Update The Geological Society dependents (JabRef#4751) 9d3f0f5 Update technische-universitat-dresden-linguistik.csl (JabRef#4737) 63d657c change et al. min (JabRef#4736) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 1e20dbd
github-actions bot
pushed a commit
to ShikunXiong/jabref
that referenced
this pull request
May 15, 2020
586e0b8 Reindent/reorder 56cd2cb small fixes for skene-journal-of-theatre-and-drama-studies.csl (JabRef#4779) 31ab72f fix demote-non-dropping-particle for equine-veterinary-education.csl (JabRef#4778) 93d409f Create skene-journal-of-theatre-and-drama-studies.csl (JabRef#4776) 06ab6ec Update groupe-danthropologie-et-darcheologie-funeraire.csl (JabRef#4777) 3b27a45 Create archaeonautica.csl (JabRef#4775) 0e0acb7 Create antafr.csl (JabRef#4774) 5dad23d Create monash-university-csiro.csl (JabRef#4773) c35d219 Create journal-of-the-royal-society-of-western-australia.csl (JabRef#4772) e772607 Update journal-of-the-royal-society-of-western-australia.csl c4b5edc Update journal-of-the-royal-society-of-western-australia.csl 2245fb1 Update journal-of-the-royal-society-of-western-australia.csl e8bcb31 Create journal-of-the-royal-society-of-western-australia.csl 270cd32 small fixes for revista-biblica.csl (JabRef#4770) 5dd7ede fix issue with DOI URL for unified-style-sheet-for-linguistics.csl (JabRef#4765) 9556b12 Create the-american-journal-of-bioethics.csl (JabRef#4766) d50c761 fix initials of revista-biblica.csl (JabRef#4768) acbb043 Create nwu-harvard-2020.csl (JabRef#4762) cb19d25 Create revista-biblica.csl (JabRef#4763) d40b5ff Small corrections in IFAO style (JabRef#4761) ba4dd7c Add NZ Journal of History (JabRef#4760) 1e20dbd Harvard Stellenbosch: Further et al adjustment a59a17e Update american-medical-association.csl to version 11 (JabRef#4727) 22849dd Create unified-style-sheet-for-linguistics-de-gruyter-literature.csl (JabRef#4627) 647fb56 Update karabuk-university-graduate-school-of-natural-and-applied-scie… (JabRef#4756) a4317f2 Update quaternaire.csl (JabRef#4752) 36fe9c2 Update journal-of-management-studies.csl (JabRef#4740) f0cb15d Bugfix (JabRef#4750) ef19002 Revert 1 yrg23 patch 1 (JabRef#4754) 873fc9e Update the-geological-society-of-london.csl (JabRef#4738) 93ca354 Update The Geological Society dependents (JabRef#4751) 9d3f0f5 Update technische-universitat-dresden-linguistik.csl (JabRef#4737) 63d657c change et al. min (JabRef#4736) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 586e0b8
github-actions bot
pushed a commit
to CaptainDaVinci/jabref
that referenced
this pull request
May 15, 2020
586e0b8 Reindent/reorder 56cd2cb small fixes for skene-journal-of-theatre-and-drama-studies.csl (JabRef#4779) 31ab72f fix demote-non-dropping-particle for equine-veterinary-education.csl (JabRef#4778) 93d409f Create skene-journal-of-theatre-and-drama-studies.csl (JabRef#4776) 06ab6ec Update groupe-danthropologie-et-darcheologie-funeraire.csl (JabRef#4777) 3b27a45 Create archaeonautica.csl (JabRef#4775) 0e0acb7 Create antafr.csl (JabRef#4774) 5dad23d Create monash-university-csiro.csl (JabRef#4773) c35d219 Create journal-of-the-royal-society-of-western-australia.csl (JabRef#4772) e772607 Update journal-of-the-royal-society-of-western-australia.csl c4b5edc Update journal-of-the-royal-society-of-western-australia.csl 2245fb1 Update journal-of-the-royal-society-of-western-australia.csl e8bcb31 Create journal-of-the-royal-society-of-western-australia.csl 270cd32 small fixes for revista-biblica.csl (JabRef#4770) 5dd7ede fix issue with DOI URL for unified-style-sheet-for-linguistics.csl (JabRef#4765) 9556b12 Create the-american-journal-of-bioethics.csl (JabRef#4766) d50c761 fix initials of revista-biblica.csl (JabRef#4768) acbb043 Create nwu-harvard-2020.csl (JabRef#4762) cb19d25 Create revista-biblica.csl (JabRef#4763) d40b5ff Small corrections in IFAO style (JabRef#4761) ba4dd7c Add NZ Journal of History (JabRef#4760) 1e20dbd Harvard Stellenbosch: Further et al adjustment a59a17e Update american-medical-association.csl to version 11 (JabRef#4727) 22849dd Create unified-style-sheet-for-linguistics-de-gruyter-literature.csl (JabRef#4627) 647fb56 Update karabuk-university-graduate-school-of-natural-and-applied-scie… (JabRef#4756) a4317f2 Update quaternaire.csl (JabRef#4752) 36fe9c2 Update journal-of-management-studies.csl (JabRef#4740) f0cb15d Bugfix (JabRef#4750) ef19002 Revert 1 yrg23 patch 1 (JabRef#4754) 873fc9e Update the-geological-society-of-london.csl (JabRef#4738) 93ca354 Update The Geological Society dependents (JabRef#4751) 9d3f0f5 Update technische-universitat-dresden-linguistik.csl (JabRef#4737) 63d657c change et al. min (JabRef#4736) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 586e0b8
github-actions bot
pushed a commit
to NikodemKch/jabref-1
that referenced
this pull request
May 15, 2020
586e0b8 Reindent/reorder 56cd2cb small fixes for skene-journal-of-theatre-and-drama-studies.csl (JabRef#4779) 31ab72f fix demote-non-dropping-particle for equine-veterinary-education.csl (JabRef#4778) 93d409f Create skene-journal-of-theatre-and-drama-studies.csl (JabRef#4776) 06ab6ec Update groupe-danthropologie-et-darcheologie-funeraire.csl (JabRef#4777) 3b27a45 Create archaeonautica.csl (JabRef#4775) 0e0acb7 Create antafr.csl (JabRef#4774) 5dad23d Create monash-university-csiro.csl (JabRef#4773) c35d219 Create journal-of-the-royal-society-of-western-australia.csl (JabRef#4772) e772607 Update journal-of-the-royal-society-of-western-australia.csl c4b5edc Update journal-of-the-royal-society-of-western-australia.csl 2245fb1 Update journal-of-the-royal-society-of-western-australia.csl e8bcb31 Create journal-of-the-royal-society-of-western-australia.csl 270cd32 small fixes for revista-biblica.csl (JabRef#4770) 5dd7ede fix issue with DOI URL for unified-style-sheet-for-linguistics.csl (JabRef#4765) 9556b12 Create the-american-journal-of-bioethics.csl (JabRef#4766) d50c761 fix initials of revista-biblica.csl (JabRef#4768) acbb043 Create nwu-harvard-2020.csl (JabRef#4762) cb19d25 Create revista-biblica.csl (JabRef#4763) d40b5ff Small corrections in IFAO style (JabRef#4761) ba4dd7c Add NZ Journal of History (JabRef#4760) 1e20dbd Harvard Stellenbosch: Further et al adjustment a59a17e Update american-medical-association.csl to version 11 (JabRef#4727) 22849dd Create unified-style-sheet-for-linguistics-de-gruyter-literature.csl (JabRef#4627) 647fb56 Update karabuk-university-graduate-school-of-natural-and-applied-scie… (JabRef#4756) a4317f2 Update quaternaire.csl (JabRef#4752) 36fe9c2 Update journal-of-management-studies.csl (JabRef#4740) f0cb15d Bugfix (JabRef#4750) ef19002 Revert 1 yrg23 patch 1 (JabRef#4754) 873fc9e Update the-geological-society-of-london.csl (JabRef#4738) 93ca354 Update The Geological Society dependents (JabRef#4751) 9d3f0f5 Update technische-universitat-dresden-linguistik.csl (JabRef#4737) 63d657c change et al. min (JabRef#4736) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 586e0b8
github-actions bot
pushed a commit
to eetian/jabref
that referenced
this pull request
May 15, 2020
586e0b8 Reindent/reorder 56cd2cb small fixes for skene-journal-of-theatre-and-drama-studies.csl (JabRef#4779) 31ab72f fix demote-non-dropping-particle for equine-veterinary-education.csl (JabRef#4778) 93d409f Create skene-journal-of-theatre-and-drama-studies.csl (JabRef#4776) 06ab6ec Update groupe-danthropologie-et-darcheologie-funeraire.csl (JabRef#4777) 3b27a45 Create archaeonautica.csl (JabRef#4775) 0e0acb7 Create antafr.csl (JabRef#4774) 5dad23d Create monash-university-csiro.csl (JabRef#4773) c35d219 Create journal-of-the-royal-society-of-western-australia.csl (JabRef#4772) e772607 Update journal-of-the-royal-society-of-western-australia.csl c4b5edc Update journal-of-the-royal-society-of-western-australia.csl 2245fb1 Update journal-of-the-royal-society-of-western-australia.csl e8bcb31 Create journal-of-the-royal-society-of-western-australia.csl 270cd32 small fixes for revista-biblica.csl (JabRef#4770) 5dd7ede fix issue with DOI URL for unified-style-sheet-for-linguistics.csl (JabRef#4765) 9556b12 Create the-american-journal-of-bioethics.csl (JabRef#4766) d50c761 fix initials of revista-biblica.csl (JabRef#4768) acbb043 Create nwu-harvard-2020.csl (JabRef#4762) cb19d25 Create revista-biblica.csl (JabRef#4763) d40b5ff Small corrections in IFAO style (JabRef#4761) ba4dd7c Add NZ Journal of History (JabRef#4760) 1e20dbd Harvard Stellenbosch: Further et al adjustment a59a17e Update american-medical-association.csl to version 11 (JabRef#4727) 22849dd Create unified-style-sheet-for-linguistics-de-gruyter-literature.csl (JabRef#4627) 647fb56 Update karabuk-university-graduate-school-of-natural-and-applied-scie… (JabRef#4756) a4317f2 Update quaternaire.csl (JabRef#4752) 36fe9c2 Update journal-of-management-studies.csl (JabRef#4740) f0cb15d Bugfix (JabRef#4750) ef19002 Revert 1 yrg23 patch 1 (JabRef#4754) 873fc9e Update the-geological-society-of-london.csl (JabRef#4738) 93ca354 Update The Geological Society dependents (JabRef#4751) 9d3f0f5 Update technische-universitat-dresden-linguistik.csl (JabRef#4737) 63d657c change et al. min (JabRef#4736) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 586e0b8
github-actions bot
pushed a commit
to dextep/jabref
that referenced
this pull request
May 15, 2020
586e0b8 Reindent/reorder 56cd2cb small fixes for skene-journal-of-theatre-and-drama-studies.csl (JabRef#4779) 31ab72f fix demote-non-dropping-particle for equine-veterinary-education.csl (JabRef#4778) 93d409f Create skene-journal-of-theatre-and-drama-studies.csl (JabRef#4776) 06ab6ec Update groupe-danthropologie-et-darcheologie-funeraire.csl (JabRef#4777) 3b27a45 Create archaeonautica.csl (JabRef#4775) 0e0acb7 Create antafr.csl (JabRef#4774) 5dad23d Create monash-university-csiro.csl (JabRef#4773) c35d219 Create journal-of-the-royal-society-of-western-australia.csl (JabRef#4772) e772607 Update journal-of-the-royal-society-of-western-australia.csl c4b5edc Update journal-of-the-royal-society-of-western-australia.csl 2245fb1 Update journal-of-the-royal-society-of-western-australia.csl e8bcb31 Create journal-of-the-royal-society-of-western-australia.csl 270cd32 small fixes for revista-biblica.csl (JabRef#4770) 5dd7ede fix issue with DOI URL for unified-style-sheet-for-linguistics.csl (JabRef#4765) 9556b12 Create the-american-journal-of-bioethics.csl (JabRef#4766) d50c761 fix initials of revista-biblica.csl (JabRef#4768) acbb043 Create nwu-harvard-2020.csl (JabRef#4762) cb19d25 Create revista-biblica.csl (JabRef#4763) d40b5ff Small corrections in IFAO style (JabRef#4761) ba4dd7c Add NZ Journal of History (JabRef#4760) 1e20dbd Harvard Stellenbosch: Further et al adjustment a59a17e Update american-medical-association.csl to version 11 (JabRef#4727) 22849dd Create unified-style-sheet-for-linguistics-de-gruyter-literature.csl (JabRef#4627) 647fb56 Update karabuk-university-graduate-school-of-natural-and-applied-scie… (JabRef#4756) a4317f2 Update quaternaire.csl (JabRef#4752) 36fe9c2 Update journal-of-management-studies.csl (JabRef#4740) f0cb15d Bugfix (JabRef#4750) ef19002 Revert 1 yrg23 patch 1 (JabRef#4754) 873fc9e Update the-geological-society-of-london.csl (JabRef#4738) 93ca354 Update The Geological Society dependents (JabRef#4751) 9d3f0f5 Update technische-universitat-dresden-linguistik.csl (JabRef#4737) 63d657c change et al. min (JabRef#4736) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 586e0b8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.