Throw BibEntryNotFound exception in case entry is no longer present #4935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
added
the
status: ready-for-review
matthiasgeiger
approved these changes
May 1, 2019
| @@ -717,6 +717,9 @@ private String getCitationMarkerField(BibEntry entry, BibDatabase database, Stri | |||
| String authorField = getStringCitProperty(AUTHOR_FIELD); | |||
| String[] fields = field.split(FieldName.FIELD_SEPARATOR); | |||
| for (String s : fields) { | |||
|
|
|||
| Objects.requireNonNull(entry, "Entry cannot be null"); | |||
| Objects.requireNonNull(database, "database cannot be null"); | |||
There was a problem hiding this comment.
Should be moved to the beginning of the method.
CHANGELOG.md
Outdated
| @@ -113,6 +113,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `# | |||
| - We fixed an issue where ranking an entry would generate an IllegalArgumentException. [#4754](https://github.com/JabRef/jabref/issues/4754) | |||
| - We fixed an issue where special characters where removed from non label key generation pattern parts [#4767](https://github.com/JabRef/jabref/issues/4767) | |||
| - We fixed an issue where the RIS import would overwite the article date with the value of the acessed date [#4816](https://github.com/JabRef/jabref/issues/4816) | |||
| - We fixed an issue where an NullPointer exception was thrown when a referenced entry in an Open/Libre Office was no longer present in the library. Now an error message with the reference marker of the missing entry is shown. [#4932](https://github.com/JabRef/jabref/issues/4932) | |||
There was a problem hiding this comment.
... in an Open/Libre Office document was...
Siedlerchr
added a commit
that referenced
this pull request
May 1, 2019
* upstream/master: Throw BibEntryNotFound exception in case entry is no longer present (#4935) Improve author parsing (#4931) Ui preferences global modifications (#4926) Bump checkstyle from 8.19 to 8.20 (#4928) Bump mysql-connector-java from 8.0.15 to 8.0.16 (#4924) UI Preferences->advanced tab optimization : separators and text modification (#4922) # Conflicts: # src/main/java/org/jabref/gui/search/SearchWorker.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4932
When an entry got removed a NPE complaining about an empty database was thrown because of some weird UnkownBibTexEntry thing.
Now the correct BibEntryNotFound Exception is thrown showing the problematic reference mark