Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes remaining issues in #4844 #4950

Merged
merged 2 commits into from
May 4, 2019
Merged

fixes remaining issues in #4844 #4950

merged 2 commits into from
May 4, 2019

Conversation

matthiasgeiger
Copy link
Member

@matthiasgeiger matthiasgeiger commented May 4, 2019 •
edited by Siedlerchr
Loading

Fixes #4844

As usual the situation was not as easy as it seemed to be in #4887. I reused now the existing renaming logic for "renaming to suggested filename" which performs some more checks like not to overwrite existing files and also takes the "file directory" settings into account.

Thus, this should fix the remaining problem mentioned in #4844.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@matthiasgeiger matthiasgeiger added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label May 4, 2019
tobiasdiez
tobiasdiez approved these changes May 4, 2019
View reviewed changes
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Siedlerchr Siedlerchr merged commit 6348f64 into master May 4, 2019
@Siedlerchr Siedlerchr deleted the followup-4844 branch May 4, 2019 10:44
Siedlerchr added a commit that referenced this pull request May 4, 2019
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into convertSearchWorker
572b8a1 
* upstream/master:
  fixes remaining issues in #4844 (#4950)
  Fix threading issue with opening from recent libraries (#4943)
  New translations JabRef_en.properties (German) (#4946)
  New Crowdin translations (#4945)
  New Crowdin translations (#4944)
  Extract build plugins (#4934)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez approved these changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Direct file renaming
3 participants
@matthiasgeiger @Siedlerchr @tobiasdiez