Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #3920 #5131

Closed
wants to merge 4 commits into from
Closed

Fix issue #3920 #5131

wants to merge 4 commits into from

Conversation

clodoaldoBasaglia
Copy link

It's a small fix for the Issue #3920 .

We made a small change on src/main/java/org/jabref/logic/bibtexkeypattern/BracketedPattern.java on the method authEtal. Where, before returning the value, we check the String and change if needed.
This fix pass both tests created stefan-kolb on the discussion thread.

@Siedlerchr
Copy link
Member

Thanks for the contribution, however it seems your fork of JabRef is not up to date. Please merge the latest changes from JabRef master branch.
And second, it's better if you create your changes on a new branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants