Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix encoding issues in xjc code generation #5339

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Conversation

matthiasgeiger
Copy link
Member

As mentioned in gitter chat there were currently some encoding issues with the XJC generation of java files based on XSDs.

I've added the encoding parameter to our XJC gradle task with default value of UTF8.


  • [ ] Change in CHANGELOG.md described
  • [ ] Tests created for changes
  • Manually tested changed features in running JabRef
  • [ ] Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • [ ] Check documentation status (Issue created for outdated help page at help.jabref.org?)

@matthiasgeiger matthiasgeiger added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 23, 2019
@Siedlerchr Siedlerchr merged commit caafef1 into master Sep 24, 2019
@Siedlerchr Siedlerchr deleted the fix-xjc-encoding branch September 24, 2019 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants