Add tests for month issue and strings (and some minor code impr… #5531

koppor · 2019-10-27T19:26:19Z

I wanted to dive into #5283 and finish it. I saw that we have no tests for month = apr (which is rendered internally as #apr#). We also did not cover the examples of https://github.com/JabRef/help.jabref.org/blob/gh-pages/en/Strings.md in test.

This is fixed here. I also did some cleaning in BibEntry. See below for details:

Add tests for month = apr and month = "apr"
Add tests for JabRef's string types
Remove Optional as method parameter in BibEntry.setField
Add builder to BibEntry
Mark "BIBTEX_STRING" as JabRef-internal field
Sort constants in InternalField.java - and add some comments

- Add tests for `month = apr` and `month = "apr"` - Add tests for JabRef's string types - Remove Optional as method parameter in BibEntry.setField - Add builder to BibEntry - Mark "BIBTEX_STRING" as JabRef-internal field - Sort constants in InternalField.java - and add some comments

src/test/resources/testbib/articleWithMonths.bib

tobiasdiez

Cool, coding-Olly is back! Code looks good to me, except a few minor things.

src/main/java/org/jabref/model/entry/BibEntry.java

tobiasdiez · 2019-10-27T21:12:03Z

src/main/java/org/jabref/model/entry/field/InternalField.java

    OWNER("owner"),
    TIMESTAMP("timestamp", FieldProperty.DATE),
    GROUPS("groups"),
    KEY_FIELD("bibtexkey"),
    TYPE_HEADER("entrytype"),
    OBSOLETE_TYPE_HEADER("bibtextype"),
-    BIBTEX_STRING("__string"),
+    // all field names starting with "Jabref-internal-" are not appearing in .bib files
+    BIBTEX_STRING("JabRef-internal-bibtex-string"), // marker that the content is just a BibTeX string


Changing these values might lead to problems as they are (maybe) stored in bib files as keys for save actions or in the preferences.

I checked the usage of this string. It is called at the formatter only.

Ok, but all and all-text-field should be used elsewhere too.

I really thought on these things and they MUST NOT stored in bib files. Otherwise, something will go completely wrong.

If I'm not mistaken, they are used in the serialization of save actions, e.g.

@Comment{ jabref-meta: saveActions:enabled; all[normalize_month] }

Ups. OK, I put the old values back.

tobiasdiez · 2019-10-27T21:14:36Z

src/test/java/org/jabref/logic/exporter/BibtexDatabaseWriterTest.java

@@ -289,7 +289,56 @@ void writeEntryWithCustomizedTypeAlsoWritesTypeDeclaration() throws Exception {
    }

    @Test
-    void roundtrip() throws Exception {
+    void writeEntryWithConstantMonthApril() throws Exception {
+        BibEntry entry = new BibEntry.Builder(StandardEntryType.Misc)


These tests should go to the BibEntryWriterTest as they are more concerned with a single entry than a complete database

tobiasdiez · 2019-10-27T21:15:24Z

src/test/java/org/jabref/logic/exporter/BibtexDatabaseWriterTest.java

+
+        databaseWriter.savePartOfDatabase(context, result.getDatabase().getEntries());
+        try (Scanner scanner = new Scanner(testBibtexFile, encoding.name())) {
+            assertEquals(scanner.useDelimiter("\\A").next(), stringWriter.toString());


use Files.readAllLines instead of the Scanner?

I tried Files.readString. Failed, because of newline issues (LF vs. CRLF).

I came up with

Files.readAllLines(testBibtexFile, Charset.forName(encoding.name())).stream().collect(Collectors.joining(OS.NEWLINE)) + OS.NEWLINE

Feels more complicated and I can't really get it to work as the assertion fails, but "Contents are equal"

- remove builder - move tests - replace scanner by Files

stefan-kolb · 2019-10-28T21:35:08Z

src/main/java/org/jabref/logic/shared/DBMSSynchronizer.java

@@ -192,7 +192,10 @@ public void synchronizeLocalDatabase() {
                            localEntry.getSharedBibEntryData()
                                      .setVersion(sharedEntry.get().getSharedBibEntryData().getVersion());
                            for (Field field : sharedEntry.get().getFields()) {
-                                localEntry.setField(field, sharedEntry.get().getField(field), EntryEventSource.SHARED);
+                                Optional<String> sharedFieldValue = sharedEntry.get().getField(field);
+                                if (sharedFieldValue.isPresent()) {


This should be a good use case for ifPresent lambda, I guess.

sharedEntry.get().getField(field).ifPresent((v) -> localEntry.setField)

Thank you for hint. I fixed a modification of an unmodifiable collection. Seems that this feature is used very seldom. Hope, it gets better.

stefan-kolb · 2019-10-28T21:42:18Z

src/test/java/org/jabref/logic/bibtex/BibEntryWriterTest.java

+        assertEquals(OS.NEWLINE +
+                "@Misc{," + OS.NEWLINE +
+                "  month = apr," + OS.NEWLINE +
+                "}" + OS.NEWLINE + OS.NEWLINE +
+                "@Comment{jabref-meta: databaseType:bibtex;}" + OS.NEWLINE, stringWriter.toString());


We could use multiple replace here like:

String.format("%1$s@Misc{,%1$s month = apr,%1$s}%1$s%1$s@Comment{jabref-meta: databaseType:bibtex;}", OS.NEWLINE);

Not sure if it's less code and better readable tho.

36ba508 Update civilta-italiana.csl (#5531) 3ea7d02 Only "page" locators are ommited in book citations in JuS journal. (#5532) 1851a54 Create alternatif-politika.csl (#5527) f30aadb [norsk-henvisningsstandard] Fix wrong article title prefix (period to comma) (#5529) e2f404e PAIN: Remove book pages&label b483372 Create urad-za-makroekonomske-analize-in-razvoj.csl (#5520) 76ac3d7 Bugfixes and improvements to the handling of the editors term for norsk-henvisningsstandard-for-rettsvitenskepelige-tekster.csl. (#5515) afe5685 Create monograph-of-the-palaeontographical-society.csl (#5521) 03d40ad Create stellenbosch-university-harvard-2021.csl (#5524) 1112d83 Update ios-press-books.csl (#5522) 5e5957d Create wirtschaftsuniversitat-wien-institut-fur-transportwirtschaft-u… (#5419) fb9fe50 update acta hydrotechnica (#5525) c576359 Patch 4 (#5510) a46174d Create social-anthropology.csl (#5512) a91627c Create orthopaedic-journal-of-sports-medicine.csl (#5511) 315fd4c Create fundamental-and-applied-limnology.csl (#5514) f4b3327 Create acta-hydrotechnica.csl (#5516) ff9b2b5 Update ocean-and-coastal-research.csl (#5517) 52f9d99 Improvements to norsk-henvisningsstandard-for-rettsvitenskapelige-tekster.csl (#5507) a3706b1 Fix ArchéoSciences (#5506) daeadd3 Update hawaii-international-conference-on-system-sciences-proceedings… (#5505) 225b9c0 Create saglik-bilimleri-universitesi.csl (#5295) 7205734 Create health-education-england-harvard-citation-style.csl (#5345) b2085cb Adicionar ponto e espaço antes de "Disponível em:" (#5367) f3eb50a Create apa6-for-international-journal-of-learner-corpus-research.csl (#5430) ff34f5c Update fachhochschule-vorarlberg-note.csl (#5502) 5aa48f7 Update fachhochschule-vorarlberg-author-date.csl (#5501) 717fba3 Create apa6-for-register-studies.csl (#5458) 147689b Update food-and-agriculture-organization-of-the-united-nations.csl (#5492) e35ae39 New citation style: "Norsk henvisningsstandard for rettsvitenskapelige tekster" (validated) (#5494) 7ff9389 revise Manchester Univ. Press style (note-bib) (#5500) 9e97809 move citation number outside first field (#5499) b08e5d7 Update APA disambiguation rules to only initials (#5498) 5d1629f Create arbok-hins-islenzka-fornleifafelags.csl (#5497) 3a2ff5f Create novasinergia.csl (#5489) 35920e2 Update din-1505-2.csl (#5491) 197486e Create zeitschrift-fuer-fantastikforschung.csl (#5490) 2cd6364 Create artificial-organs.csl (#5340) 5ea7955 Create society-of-biblical-literature-1st-edition-fullnote-bibliography (#5421) d0de451 Create Journal of Move and Therapeutic Science (#5486) 899c2bc Update ACS documentation & date format 950f730 Create ulua-revista-de-historia-sociedad-y-cultura.csl (#5478) a1c34f5 Update wirtschaftsuniversitat-wien-institut-fur-bwl-des-aussenhandels.csl (#5470) 79fa66e Update gallia-prehistoire.csl (#5467) 2f1df12 Update hochschule-bonn-rhein-sieg.csl (#5479) 06078c6 Update acta-universitatis-agriculturae-sueciae.csl (#5409) 3650206 Update ethnographiques-org.csl (#5480) e06cc90 remove et-al from restoration-ecology.csl (#5485) 4e4e1f3 Presses universitaires de Strasbourg – Fix op.cit and multiple items (#5484) f8ff160 Create UWE-Bristol-Harvard-2021.csl (#5482) 10a1d17 Fix authors delimiter (#5483) f53ff57 Update stuttgart-media-university.csl (#5477) c7a01e0 Create worlds-veterinary-journal.csl (#5468) ec923b2 Update experimental-biology-and-medicine.csl (#5469) 1d48cb7 Create plant-species-biology.csl (#5471) ea68765 Create ethnographiques-org.csl (#5472) 0e1c470 Update harvard-bournemouth-university.csl (#5476) 96e8114 Use date issued in web documents if exists (#5418) 8377ec8 Create bibliothecae-it.csl (#5440) a5707e7 Create bppb.csl (#5452) dc0e509 Create babesch-annual-papers-on-mediterranean-archaeology.csl (#5424) 62aa816 Bump nokogiri from 1.11.1 to 1.11.4 (#5460) 47a603c Update society-of-biblical-literature-fullnote-bibliography.csl (#5436) 1de799b SAA: Update disambiguation 46da8c6 Update iso690-author-date-cs.csl (#5443) 2a74991 Exempt ISSNs for Topoi journal (#5444) a0f3130 show test directories f9ce567 Updates ( -> [ (#5347) c3910dd IEEE.csl - Add "I. Online Video (e.g., YouTube)" (#5365) d37f39a Update estudios-hispanicos.csl (#5417) 931c057 Create topoi-orient-occident-classique.csl (#5427) 70ee747 Create topoi-orient-occident-auteur-date.csl (#5426) 8ea5ed2 Update universite-de-montreal-apa.csl (#5428) f0dcb04 Update the-horticulture-journal.csl (#5437) 767df6d Update transnational-environmental-law.csl (#5435) 1e63dfe Update environmental-values.csl to match requirements (#5355) 94163d8 Create studies-in-the-history-of-gardens-and-designed-landscapes.csl (#5425) 21dd881 Create journal-of-stroke.csl (#5429) 937ce4b Update the-plant-genome.csl (#5432) 996e217 Update springer-basic-author-date-no-et-al.csl (#5431) 7dd1f44 Update taylor-and-francis-council-of-science-editors-author-date.csl (#5433) 141be9b Update civilta-italiana.csl (#5434) 10b2222 small fixes for jopr.csl (#5422) bf59a9f Create jci-insight.csl (#5423) 9aebd58 Update mammalia.csl (#5404) 77dcd74 Update gost-r-7-0-5-2008 styles (#5412) 5d348dd Update journal-of-oil-palm-research.csl (#5403) 55f6eda Adds missing space after title and moves space from title prefix to author suffix. (#5407) b5df1a8 Fixed Mendeley bug (#5411) 49530b4 Create the-journal-of-laryngology-and-otology.csl (#5410) 6d95f75 Create college-research-libraries.csl (#5406) 9876e81 Create biostatistics.csl (#5372) 673db49 Update revue-forestiere-francaise.csl (#5387) 474cc2e Create oil-shale.csl (#5389) 249ad6a Updating infoclio.ch styles (#5391) 6dc6742 Update ocean-and-coastal-research.csl (#5392) 1e75c74 Update and rename dependent/experimental-biology-and-medicine.csl to … (#5398) 0a072f8 Update universite-du-quebec-a-montreal.csl (#5399) 373d684 Create the-bovine-practitioner.csl (#5400) cdbb6ed Create journal-of-oil-palm-research.csl (#5388) a75cb35 Update south-african-medical-journal.csl (#5393) a35360f Update journal-of-nutrition.csl (#5397) ef215ac Update and rename journal-of-neurosurgery.csl to dependent/journal-of… (make AMA dependent) (#5359) c435731 Create ocean-and-coastal-research.csl (#5364) 561024e Create istanbul-medical-journal.csl (#5374) 21ba5d8 Update aquatic-conservation.csl (#5379) c83c4a9 Create endocrine-connections.csl (#5380) 7da88e9 Update society-of-biblical-literature-fullnote-bibliography.csl (#5381) ca27bc1 Update university-of-york-harvard-environment.csl (#5384) df54422 Update university-of-york-harvard-archaeology.csl (#5385) 4439cdd Create revue-forestiere-francaise.csl (#5386) c363e8f Update catholic-biblical-association.csl (#5360) 7e383b8 Fix locators in PU Paris-Nanterre (#5376) 83cb249 Update methods-of-information-in-medicine.csl (#5370) 5b19db4 Update taylor-and-francis-council-of-science-editors-author-date.csl (#5371) 27d116b Update harvard-cite-them-right-no-et-al.csl (#5373) e2ef408 Update ageing-and-society.csl (#5375) 16098e4 Update triangle.csl (#5369) 133d633 Create university-of-tasmania-simplified-author-date.csl (#5357) b9ecf07 Update revue-archeologique.csl (#5366) 6152cce Update journal-of-consumer-research.csl (#5358) 93f6600 Create refugee-survey-quarterly.csl (#5354) bfa3b6d Update canadian-biosystems-engineering.csl (#5362) 53e75ee update doi prefix (#5361) 5b3de98 Create archives-of-hand-and-microsurgery.csl (#5363) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 36ba508

* Squashed 'buildres/csl/csl-styles/' changes from e1acabe..36ba508 36ba508 Update civilta-italiana.csl (#5531) 3ea7d02 Only "page" locators are ommited in book citations in JuS journal. (#5532) 1851a54 Create alternatif-politika.csl (#5527) f30aadb [norsk-henvisningsstandard] Fix wrong article title prefix (period to comma) (#5529) e2f404e PAIN: Remove book pages&label b483372 Create urad-za-makroekonomske-analize-in-razvoj.csl (#5520) 76ac3d7 Bugfixes and improvements to the handling of the editors term for norsk-henvisningsstandard-for-rettsvitenskepelige-tekster.csl. (#5515) afe5685 Create monograph-of-the-palaeontographical-society.csl (#5521) 03d40ad Create stellenbosch-university-harvard-2021.csl (#5524) 1112d83 Update ios-press-books.csl (#5522) 5e5957d Create wirtschaftsuniversitat-wien-institut-fur-transportwirtschaft-u… (#5419) fb9fe50 update acta hydrotechnica (#5525) c576359 Patch 4 (#5510) a46174d Create social-anthropology.csl (#5512) a91627c Create orthopaedic-journal-of-sports-medicine.csl (#5511) 315fd4c Create fundamental-and-applied-limnology.csl (#5514) f4b3327 Create acta-hydrotechnica.csl (#5516) ff9b2b5 Update ocean-and-coastal-research.csl (#5517) 52f9d99 Improvements to norsk-henvisningsstandard-for-rettsvitenskapelige-tekster.csl (#5507) a3706b1 Fix ArchéoSciences (#5506) daeadd3 Update hawaii-international-conference-on-system-sciences-proceedings… (#5505) 225b9c0 Create saglik-bilimleri-universitesi.csl (#5295) 7205734 Create health-education-england-harvard-citation-style.csl (#5345) b2085cb Adicionar ponto e espaço antes de "Disponível em:" (#5367) f3eb50a Create apa6-for-international-journal-of-learner-corpus-research.csl (#5430) ff34f5c Update fachhochschule-vorarlberg-note.csl (#5502) 5aa48f7 Update fachhochschule-vorarlberg-author-date.csl (#5501) 717fba3 Create apa6-for-register-studies.csl (#5458) 147689b Update food-and-agriculture-organization-of-the-united-nations.csl (#5492) e35ae39 New citation style: "Norsk henvisningsstandard for rettsvitenskapelige tekster" (validated) (#5494) 7ff9389 revise Manchester Univ. Press style (note-bib) (#5500) 9e97809 move citation number outside first field (#5499) b08e5d7 Update APA disambiguation rules to only initials (#5498) 5d1629f Create arbok-hins-islenzka-fornleifafelags.csl (#5497) 3a2ff5f Create novasinergia.csl (#5489) 35920e2 Update din-1505-2.csl (#5491) 197486e Create zeitschrift-fuer-fantastikforschung.csl (#5490) 2cd6364 Create artificial-organs.csl (#5340) 5ea7955 Create society-of-biblical-literature-1st-edition-fullnote-bibliography (#5421) d0de451 Create Journal of Move and Therapeutic Science (#5486) 899c2bc Update ACS documentation & date format 950f730 Create ulua-revista-de-historia-sociedad-y-cultura.csl (#5478) a1c34f5 Update wirtschaftsuniversitat-wien-institut-fur-bwl-des-aussenhandels.csl (#5470) 79fa66e Update gallia-prehistoire.csl (#5467) 2f1df12 Update hochschule-bonn-rhein-sieg.csl (#5479) 06078c6 Update acta-universitatis-agriculturae-sueciae.csl (#5409) 3650206 Update ethnographiques-org.csl (#5480) e06cc90 remove et-al from restoration-ecology.csl (#5485) 4e4e1f3 Presses universitaires de Strasbourg – Fix op.cit and multiple items (#5484) f8ff160 Create UWE-Bristol-Harvard-2021.csl (#5482) 10a1d17 Fix authors delimiter (#5483) f53ff57 Update stuttgart-media-university.csl (#5477) c7a01e0 Create worlds-veterinary-journal.csl (#5468) ec923b2 Update experimental-biology-and-medicine.csl (#5469) 1d48cb7 Create plant-species-biology.csl (#5471) ea68765 Create ethnographiques-org.csl (#5472) 0e1c470 Update harvard-bournemouth-university.csl (#5476) 96e8114 Use date issued in web documents if exists (#5418) 8377ec8 Create bibliothecae-it.csl (#5440) a5707e7 Create bppb.csl (#5452) dc0e509 Create babesch-annual-papers-on-mediterranean-archaeology.csl (#5424) 62aa816 Bump nokogiri from 1.11.1 to 1.11.4 (#5460) 47a603c Update society-of-biblical-literature-fullnote-bibliography.csl (#5436) 1de799b SAA: Update disambiguation 46da8c6 Update iso690-author-date-cs.csl (#5443) 2a74991 Exempt ISSNs for Topoi journal (#5444) a0f3130 show test directories f9ce567 Updates ( -> [ (#5347) c3910dd IEEE.csl - Add "I. Online Video (e.g., YouTube)" (#5365) d37f39a Update estudios-hispanicos.csl (#5417) 931c057 Create topoi-orient-occident-classique.csl (#5427) 70ee747 Create topoi-orient-occident-auteur-date.csl (#5426) 8ea5ed2 Update universite-de-montreal-apa.csl (#5428) f0dcb04 Update the-horticulture-journal.csl (#5437) 767df6d Update transnational-environmental-law.csl (#5435) 1e63dfe Update environmental-values.csl to match requirements (#5355) 94163d8 Create studies-in-the-history-of-gardens-and-designed-landscapes.csl (#5425) 21dd881 Create journal-of-stroke.csl (#5429) 937ce4b Update the-plant-genome.csl (#5432) 996e217 Update springer-basic-author-date-no-et-al.csl (#5431) 7dd1f44 Update taylor-and-francis-council-of-science-editors-author-date.csl (#5433) 141be9b Update civilta-italiana.csl (#5434) 10b2222 small fixes for jopr.csl (#5422) bf59a9f Create jci-insight.csl (#5423) 9aebd58 Update mammalia.csl (#5404) 77dcd74 Update gost-r-7-0-5-2008 styles (#5412) 5d348dd Update journal-of-oil-palm-research.csl (#5403) 55f6eda Adds missing space after title and moves space from title prefix to author suffix. (#5407) b5df1a8 Fixed Mendeley bug (#5411) 49530b4 Create the-journal-of-laryngology-and-otology.csl (#5410) 6d95f75 Create college-research-libraries.csl (#5406) 9876e81 Create biostatistics.csl (#5372) 673db49 Update revue-forestiere-francaise.csl (#5387) 474cc2e Create oil-shale.csl (#5389) 249ad6a Updating infoclio.ch styles (#5391) 6dc6742 Update ocean-and-coastal-research.csl (#5392) 1e75c74 Update and rename dependent/experimental-biology-and-medicine.csl to … (#5398) 0a072f8 Update universite-du-quebec-a-montreal.csl (#5399) 373d684 Create the-bovine-practitioner.csl (#5400) cdbb6ed Create journal-of-oil-palm-research.csl (#5388) a75cb35 Update south-african-medical-journal.csl (#5393) a35360f Update journal-of-nutrition.csl (#5397) ef215ac Update and rename journal-of-neurosurgery.csl to dependent/journal-of… (make AMA dependent) (#5359) c435731 Create ocean-and-coastal-research.csl (#5364) 561024e Create istanbul-medical-journal.csl (#5374) 21ba5d8 Update aquatic-conservation.csl (#5379) c83c4a9 Create endocrine-connections.csl (#5380) 7da88e9 Update society-of-biblical-literature-fullnote-bibliography.csl (#5381) ca27bc1 Update university-of-york-harvard-environment.csl (#5384) df54422 Update university-of-york-harvard-archaeology.csl (#5385) 4439cdd Create revue-forestiere-francaise.csl (#5386) c363e8f Update catholic-biblical-association.csl (#5360) 7e383b8 Fix locators in PU Paris-Nanterre (#5376) 83cb249 Update methods-of-information-in-medicine.csl (#5370) 5b19db4 Update taylor-and-francis-council-of-science-editors-author-date.csl (#5371) 27d116b Update harvard-cite-them-right-no-et-al.csl (#5373) e2ef408 Update ageing-and-society.csl (#5375) 16098e4 Update triangle.csl (#5369) 133d633 Create university-of-tasmania-simplified-author-date.csl (#5357) b9ecf07 Update revue-archeologique.csl (#5366) 6152cce Update journal-of-consumer-research.csl (#5358) 93f6600 Create refugee-survey-quarterly.csl (#5354) bfa3b6d Update canadian-biosystems-engineering.csl (#5362) 53e75ee update doi prefix (#5361) 5b3de98 Create archives-of-hand-and-microsurgery.csl (#5363) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 36ba508 * Squashed 'buildres/csl/csl-locales/' changes from 79c4dba80a..ec6d62a9e7 ec6d62a9e7 Merge pull request #231 from Pendzoncymisio/master 06c2693b7f Update locales-pl-PL.xml 75e95a1c92 Update of PL "accessed" translation c6093128ac Update of PL "accessed" translation bd8d2dbc85 Update spec_helper for pull-request testing (#220) ed3fc7c9be Update to Ruby 3.0.0 (#218) git-subtree-dir: buildres/csl/csl-locales git-subtree-split: ec6d62a9e7c049001a55086a495022520989441c Co-authored-by: github actions <jabrefmail+webfeedback@gmail.com>

ec4a4c0 Create rassegna-degli-archivi-di-stato.csl (#5530) e3a4bb2 Update ocean-and-coastal-research.csl (#5533) aeb3ece Create bakhtiniana-journal-of-discourse-studies.csl (#5535) 36ba508 Update civilta-italiana.csl (#5531) 3ea7d02 Only "page" locators are ommited in book citations in JuS journal. (#5532) 1851a54 Create alternatif-politika.csl (#5527) f30aadb [norsk-henvisningsstandard] Fix wrong article title prefix (period to comma) (#5529) e2f404e PAIN: Remove book pages&label b483372 Create urad-za-makroekonomske-analize-in-razvoj.csl (#5520) 76ac3d7 Bugfixes and improvements to the handling of the editors term for norsk-henvisningsstandard-for-rettsvitenskepelige-tekster.csl. (#5515) afe5685 Create monograph-of-the-palaeontographical-society.csl (#5521) 03d40ad Create stellenbosch-university-harvard-2021.csl (#5524) 1112d83 Update ios-press-books.csl (#5522) 5e5957d Create wirtschaftsuniversitat-wien-institut-fur-transportwirtschaft-u… (#5419) fb9fe50 update acta hydrotechnica (#5525) c576359 Patch 4 (#5510) a46174d Create social-anthropology.csl (#5512) a91627c Create orthopaedic-journal-of-sports-medicine.csl (#5511) 315fd4c Create fundamental-and-applied-limnology.csl (#5514) f4b3327 Create acta-hydrotechnica.csl (#5516) ff9b2b5 Update ocean-and-coastal-research.csl (#5517) 52f9d99 Improvements to norsk-henvisningsstandard-for-rettsvitenskapelige-tekster.csl (#5507) a3706b1 Fix ArchéoSciences (#5506) daeadd3 Update hawaii-international-conference-on-system-sciences-proceedings… (#5505) 225b9c0 Create saglik-bilimleri-universitesi.csl (#5295) 7205734 Create health-education-england-harvard-citation-style.csl (#5345) b2085cb Adicionar ponto e espaço antes de "Disponível em:" (#5367) f3eb50a Create apa6-for-international-journal-of-learner-corpus-research.csl (#5430) ff34f5c Update fachhochschule-vorarlberg-note.csl (#5502) 5aa48f7 Update fachhochschule-vorarlberg-author-date.csl (#5501) 717fba3 Create apa6-for-register-studies.csl (#5458) 147689b Update food-and-agriculture-organization-of-the-united-nations.csl (#5492) e35ae39 New citation style: "Norsk henvisningsstandard for rettsvitenskapelige tekster" (validated) (#5494) 7ff9389 revise Manchester Univ. Press style (note-bib) (#5500) 9e97809 move citation number outside first field (#5499) b08e5d7 Update APA disambiguation rules to only initials (#5498) 5d1629f Create arbok-hins-islenzka-fornleifafelags.csl (#5497) 3a2ff5f Create novasinergia.csl (#5489) 35920e2 Update din-1505-2.csl (#5491) 197486e Create zeitschrift-fuer-fantastikforschung.csl (#5490) 2cd6364 Create artificial-organs.csl (#5340) 5ea7955 Create society-of-biblical-literature-1st-edition-fullnote-bibliography (#5421) d0de451 Create Journal of Move and Therapeutic Science (#5486) 899c2bc Update ACS documentation & date format 950f730 Create ulua-revista-de-historia-sociedad-y-cultura.csl (#5478) a1c34f5 Update wirtschaftsuniversitat-wien-institut-fur-bwl-des-aussenhandels.csl (#5470) 79fa66e Update gallia-prehistoire.csl (#5467) 2f1df12 Update hochschule-bonn-rhein-sieg.csl (#5479) 06078c6 Update acta-universitatis-agriculturae-sueciae.csl (#5409) 3650206 Update ethnographiques-org.csl (#5480) e06cc90 remove et-al from restoration-ecology.csl (#5485) 4e4e1f3 Presses universitaires de Strasbourg – Fix op.cit and multiple items (#5484) f8ff160 Create UWE-Bristol-Harvard-2021.csl (#5482) 10a1d17 Fix authors delimiter (#5483) f53ff57 Update stuttgart-media-university.csl (#5477) c7a01e0 Create worlds-veterinary-journal.csl (#5468) ec923b2 Update experimental-biology-and-medicine.csl (#5469) 1d48cb7 Create plant-species-biology.csl (#5471) ea68765 Create ethnographiques-org.csl (#5472) 0e1c470 Update harvard-bournemouth-university.csl (#5476) 96e8114 Use date issued in web documents if exists (#5418) 8377ec8 Create bibliothecae-it.csl (#5440) a5707e7 Create bppb.csl (#5452) dc0e509 Create babesch-annual-papers-on-mediterranean-archaeology.csl (#5424) 62aa816 Bump nokogiri from 1.11.1 to 1.11.4 (#5460) 47a603c Update society-of-biblical-literature-fullnote-bibliography.csl (#5436) 1de799b SAA: Update disambiguation 46da8c6 Update iso690-author-date-cs.csl (#5443) 2a74991 Exempt ISSNs for Topoi journal (#5444) a0f3130 show test directories f9ce567 Updates ( -> [ (#5347) c3910dd IEEE.csl - Add "I. Online Video (e.g., YouTube)" (#5365) d37f39a Update estudios-hispanicos.csl (#5417) 931c057 Create topoi-orient-occident-classique.csl (#5427) 70ee747 Create topoi-orient-occident-auteur-date.csl (#5426) 8ea5ed2 Update universite-de-montreal-apa.csl (#5428) f0dcb04 Update the-horticulture-journal.csl (#5437) 767df6d Update transnational-environmental-law.csl (#5435) 1e63dfe Update environmental-values.csl to match requirements (#5355) 94163d8 Create studies-in-the-history-of-gardens-and-designed-landscapes.csl (#5425) 21dd881 Create journal-of-stroke.csl (#5429) 937ce4b Update the-plant-genome.csl (#5432) 996e217 Update springer-basic-author-date-no-et-al.csl (#5431) 7dd1f44 Update taylor-and-francis-council-of-science-editors-author-date.csl (#5433) 141be9b Update civilta-italiana.csl (#5434) 10b2222 small fixes for jopr.csl (#5422) bf59a9f Create jci-insight.csl (#5423) 9aebd58 Update mammalia.csl (#5404) 77dcd74 Update gost-r-7-0-5-2008 styles (#5412) 5d348dd Update journal-of-oil-palm-research.csl (#5403) 55f6eda Adds missing space after title and moves space from title prefix to author suffix. (#5407) b5df1a8 Fixed Mendeley bug (#5411) 49530b4 Create the-journal-of-laryngology-and-otology.csl (#5410) 6d95f75 Create college-research-libraries.csl (#5406) 9876e81 Create biostatistics.csl (#5372) 673db49 Update revue-forestiere-francaise.csl (#5387) 474cc2e Create oil-shale.csl (#5389) 249ad6a Updating infoclio.ch styles (#5391) 6dc6742 Update ocean-and-coastal-research.csl (#5392) 1e75c74 Update and rename dependent/experimental-biology-and-medicine.csl to … (#5398) 0a072f8 Update universite-du-quebec-a-montreal.csl (#5399) 373d684 Create the-bovine-practitioner.csl (#5400) cdbb6ed Create journal-of-oil-palm-research.csl (#5388) a75cb35 Update south-african-medical-journal.csl (#5393) a35360f Update journal-of-nutrition.csl (#5397) ef215ac Update and rename journal-of-neurosurgery.csl to dependent/journal-of… (make AMA dependent) (#5359) c435731 Create ocean-and-coastal-research.csl (#5364) 561024e Create istanbul-medical-journal.csl (#5374) 21ba5d8 Update aquatic-conservation.csl (#5379) c83c4a9 Create endocrine-connections.csl (#5380) 7da88e9 Update society-of-biblical-literature-fullnote-bibliography.csl (#5381) ca27bc1 Update university-of-york-harvard-environment.csl (#5384) df54422 Update university-of-york-harvard-archaeology.csl (#5385) 4439cdd Create revue-forestiere-francaise.csl (#5386) c363e8f Update catholic-biblical-association.csl (#5360) 7e383b8 Fix locators in PU Paris-Nanterre (#5376) 83cb249 Update methods-of-information-in-medicine.csl (#5370) 5b19db4 Update taylor-and-francis-council-of-science-editors-author-date.csl (#5371) 27d116b Update harvard-cite-them-right-no-et-al.csl (#5373) e2ef408 Update ageing-and-society.csl (#5375) 16098e4 Update triangle.csl (#5369) 133d633 Create university-of-tasmania-simplified-author-date.csl (#5357) b9ecf07 Update revue-archeologique.csl (#5366) 6152cce Update journal-of-consumer-research.csl (#5358) 93f6600 Create refugee-survey-quarterly.csl (#5354) bfa3b6d Update canadian-biosystems-engineering.csl (#5362) 53e75ee update doi prefix (#5361) 5b3de98 Create archives-of-hand-and-microsurgery.csl (#5363) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: ec4a4c0

koppor requested a review from stefan-kolb October 27, 2019 19:26

Siedlerchr reviewed Oct 27, 2019

View reviewed changes

src/test/resources/testbib/articleWithMonths.bib Show resolved Hide resolved

tobiasdiez requested changes Oct 27, 2019

View reviewed changes

tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 27, 2019

koppor added 2 commits October 27, 2019 22:58

Adress review comments

40c2a86

- remove builder - move tests - replace scanner by Files

Use old values in InternalFields (and rearrange again)

2a46d18

stefan-kolb approved these changes Oct 28, 2019

View reviewed changes

koppor added 3 commits October 28, 2019 23:23

Fix modifiation of unmodifiable set

48d76c6

Format code

1632196

Format code and fix test

6893dc5

koppor changed the title ~~Add tests for month issue and strings (and some minor code improvements)~~ Add tests for month issue and strings (and some minor code impr… Oct 28, 2019

koppor merged commit 075f191 into master Oct 28, 2019

koppor deleted the add-string-test branch October 28, 2019 22:58

koppor mentioned this pull request Oct 28, 2019

Unify month field formatting in test bib files (JabRef/jabref#5116) #5283

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tests for month issue and strings (and some minor code impr… #5531

Add tests for month issue and strings (and some minor code impr… #5531

koppor commented Oct 27, 2019

tobiasdiez left a comment

tobiasdiez Oct 27, 2019

koppor Oct 27, 2019

tobiasdiez Oct 27, 2019

koppor Oct 27, 2019

tobiasdiez Oct 27, 2019

koppor Oct 27, 2019

tobiasdiez Oct 27, 2019

tobiasdiez Oct 27, 2019

koppor Oct 27, 2019

stefan-kolb Oct 28, 2019

stefan-kolb Oct 28, 2019

koppor Oct 28, 2019

stefan-kolb Oct 28, 2019

Add tests for month issue and strings (and some minor code impr… #5531

Add tests for month issue and strings (and some minor code impr… #5531

Conversation

koppor commented Oct 27, 2019

tobiasdiez left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment