-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to rsync #5778
Switch to rsync #5778
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Finally we have a working build again. Thanks a lot for your work, Olly!
Just a bit of nitpicking.
.github/workflows/deployment.yml
Outdated
|
||
runs-on: ${{ matrix.os }} | ||
name: Deploy on ${{ matrix.displayName }} | ||
name: Build for ${{ matrix.displayName }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is build the right terminology since we build the installer and not the application (compilation)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would guess so as "build" (for me) is to create something. Be it the plain binary, the installer, ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would guess so as "build" (for me) is to create something. Be it the plain binary, the installer, ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create installer for matrix.os ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also create the portable files. I will then use the longer name containing both.
2a5bc5a
to
b589def
Compare
Result stored at http://builds.jabref.org/switch-to-rsync/ I made the indent consistent in the yml file (and also consistent to https://help.github.com/en/actions/automating-your-workflow-with-github-actions/configuring-a-workflow) Should be ready to go now. |
rsync: failed to set times on "/var/www/builds.jabref.org/www/master/.": Operation not permitted (1) This just happened on master |
Fixed. Background: The file was owned by a different user than the rsync-user. |
* upstream/master: Fixes StringIndexOutOfBoundsException when cutting text (#5776) Bump org.beryx.jlink from 2.16.4 to 2.17.0 (#5782) Bump byte-buddy-parent from 1.10.5 to 1.10.6 (#5783) Fix line endings. Try to use implicit shell to enable variable correctly be set Fix branch name detection Update script to absolute path and new username Revert "Disable non-working cleanup_pr workflow" Switch to rsync (#5778) Fix Medline tests (#5774) Normalize line ending in test file (#5775) Fix Springer fetcher tests (#5773) Fix code style (#5772)
60bf7d5 Add encyclopedia type to wikipedia-templates.csl (#5778) 031afe1 Update and rename dependent/organization-studies.csl to organization-… (#5779) 7ed71e7 Update harvard-newcastle-university.csl (#5765) 46bab91 Update annals-of-oncology.csl (#5760) 6158ae6 Create research-in-plant-disease.csl (#5738) 04422a8 Create chemmedchem.csl (#5753) 7c11521 Create clinical-kidney-journal.csl (#5749) e7ee983 Create kit-karlsruher-institut-fur-technologie-germanistik-ndl-neuere… (#5729) 96a1106 Update article format for STM journal (#5755) a4ca057 Update historia-scribere.csl (#5748) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: 60bf7d5
Extract "best of" of #5748 to get things moving.
If this goes through, this is ready-for-review. Has some urgency as scp mostly does not work (because of our large file sizes). I am working at #5748 to reduce the file sizes.
I kept
pigz --rsyncable
since a) I want to optimize transfer b) pgiz is better than gzip (see https://superuser.com/a/1050148/138868).More background on rsyncable: https://beeznest.wordpress.com/2005/02/03/rsyncable-gzip/. Especially the link to the PhD thesis (I think by @tridge): https://www.samba.org//~tridge/phd_thesis.pdf