Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shorten exports thing #5887

Closed
wants to merge 1 commit into from
Closed

Shorten exports thing #5887

wants to merge 1 commit into from

Conversation

koppor
Copy link
Member

@koppor koppor commented Jan 28, 2020

I just need that at my exports. How about @stefan-kolb and @tobiasdiez ?

@tobiasdiez
Copy link
Member

All the add-export statements from here:

jabref/build.gradle

Lines 401 to 426 in eb988b6

jvmArgs '--add-exports', 'javafx.controls/com.sun.javafx.scene.control=org.jabref',
'--add-exports', 'org.controlsfx.controls/impl.org.controlsfx.skin=org.jabref',
'--add-opens', 'javafx.controls/javafx.scene.control=org.jabref',
'--add-opens', 'org.controlsfx.controls/org.controlsfx.control.textfield=org.jabref',
'--add-opens', 'javafx.controls/com.sun.javafx.scene.control=org.jabref',
// Not sure why we need to restate the controlfx exports
// Taken from here: https://github.com/controlsfx/controlsfx/blob/9.0.0/build.gradle#L1
"--add-exports", "javafx.graphics/com.sun.javafx.scene=org.controlsfx.controls",
"--add-exports", "javafx.graphics/com.sun.javafx.scene.traversal=org.controlsfx.controls",
"--add-exports", "javafx.graphics/com.sun.javafx.css=org.controlsfx.controls",
"--add-exports", "javafx.controls/com.sun.javafx.scene.control.behavior=org.controlsfx.controls",
"--add-exports", "javafx.controls/com.sun.javafx.scene.control=org.controlsfx.controls",
"--add-exports", "javafx.controls/com.sun.javafx.scene.control.inputmap=org.controlsfx.controls",
"--add-exports", "javafx.base/com.sun.javafx.event=org.controlsfx.controls",
"--add-exports", "javafx.base/com.sun.javafx.collections=org.controlsfx.controls",
"--add-exports", "javafx.base/com.sun.javafx.runtime=org.controlsfx.controls",
"--add-exports", "javafx.web/com.sun.webkit=org.controlsfx.controls",
"--add-exports", "javafx.graphics/com.sun.javafx.css=org.controlsfx.controls",
"--add-opens", "javafx.controls/javafx.scene.control.skin=org.controlsfx.controls",
"--add-opens", "javafx.graphics/javafx.scene=org.controlsfx.controls",
"--add-exports", "javafx.controls/com.sun.javafx.scene.control.behavior=com.jfoenix",
"--add-opens", "javafx.controls/com.sun.javafx.scene.control.behavior=com.jfoenix",
"--add-opens", "javafx.base/com.sun.javafx.binding=com.jfoenix",
"--add-opens", "javafx.graphics/com.sun.javafx.stage=com.jfoenix",
"--add-opens", "javafx.base/com.sun.javafx.event=com.jfoenix",
'--add-exports', 'com.oracle.truffle.regex/com.oracle.truffle.regex=org.graalvm.truffle'

should be needed. It could be that controlsfx improved their code and removed some of the internal access (but I doubt it, the last time I look at this they were really using internal api's that are not easily removed). Note that some of the exports are only needed for certain dialogs!

Not sure if the patch module statements are necessary. @systemoperator had some troubles with them anyway, so I guess they are safe to remove?!

@koppor koppor closed this Jan 30, 2020
@koppor
Copy link
Member Author

koppor commented Jan 30, 2020

I am not sure about my changes. Thus, I just close the PR.

@koppor koppor deleted the koppor-patch-1 branch January 30, 2020 21:49
@systemoperator systemoperator mentioned this pull request Jan 31, 2020
Merged
koppor pushed a commit that referenced this pull request Mar 1, 2022
Squashed 'buildres/csl/csl-styles/' changes from eb97405..8f69d4e
927b7e7 
8f69d4e Container-title text-case set to title (#5931)
7200616 Create arrbhousestyle.csl (#5674)
8933609 Create hospital-a-domicilio.csl (#5924)
622bf63 Create international-journal-of-cosmetic-science.csl (#5886)
07e179f remove default-locale journal-de-la-societe-des-oceanistes.csl (#5887)
4435d1e update norsk-henvisningsstandard-for-rettsvitenskapelige-tekster.csl (#5892)
18e547f Added fixes for steel-research-international.csl (#5921)
79e53a2 Update springer-basic-brackets-no-et-al.csl (#5925)
e4f411f Update antiquites-africaines.csl (#5923)
f4b3830 Create hemijska-industrija.csl (#5881)
1b33712 Create dhd.csl (#5920)
8462846 Update China national standard GB/T 7714 styles (#5860)
2c298be ISO formatted dates in sodertorns hogskola citation styles (#5882)
1114ec2 Update sodertorns-hogskola-oxford.csl (#5865)
20c439b Create boletin-de-la-sociedad-geologica-mexicana.csl (#5841)
e02b500 Create jurisprudence.csl (#5856)
a860c30 Update organization-studies.csl (#5914)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 8f69d4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koppor @tobiasdiez