Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major OpenOffice changes #602

Merged
merged 6 commits into from
Jan 5, 2016
Merged

Major OpenOffice changes #602

merged 6 commits into from
Jan 5, 2016

Conversation

oscargus
Copy link
Contributor

Assuming that the current state of the OpenOffice/LibreOffice connection is good enough (and that no one will improve it significantly in the near future), this PR removes currently unused code.

The major removed thing (from some perspective) is the .bst-support. However, as far as I can tell, it wasn't finished (and therefore not enabled) and while I really think it is a nice feature, I cannot really imagine someone finishing it.

As a second change, the push-to-application button support is removed and only the side panel can be used (which is much more advanced anyway). There are probably further things that can be removed, such as a few preferences related to push-to-application, but that will require further analysis.

This PR builds on #601, so merging that first is probably the best (and this may require some thinking).

@oscargus oscargus added cleanup-ops status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers openoffice/libreoffice labels Dec 28, 2015
@oscargus
Copy link
Contributor Author

Also "solves" #534.

@koppor
Copy link
Member

koppor commented Dec 29, 2015

I need to investigate further. In #110 I identified the bibtex VM (net.sf.jabref.bst.VM), which can handle bsts. Seems to be very complete. I am aware that citastionstyles (see #119) is the successor of bst files. I am currently unsure, whether citation styles really cover all cases and if users can easily switch.

In the case of biblatex vs. citationstyles, I am pretty sure that biblatex is more powerful. When reading the documentation of biblatex-apa, I don't think that a 621 line XML can have the same functionality. But you can convince me of the opposite. - I know that this doesn't help in the bst vs. citation styles case though.

@oscargus
Copy link
Contributor Author

oscargus commented Dec 29, 2015 via email

@koppor
Copy link
Member

koppor commented Dec 29, 2015

Could you say a few words about the expected funtionality behind insertBST or is it a mystery? 😇

@oscargus
Copy link
Contributor Author

Well, it's got a hard coded .bst file in it:

wrapper.loadBstFile(new File("/home/usr/share/texmf-tetex/bibtex/bst/ams/amsalpha.bst"));

The other indication of incompleteness is BstWrapper.java with the following method:

public Map<String, String> processEntries(Collection<BibEntry> entries, BibDatabase database) {
        // TODO: how to handle uniquefiers?

        // TODO: need handling of crossrefs?
        String result = vm.run(entries);
        return parseResult(result);
    }

In addition, IEEEtran.bst introduces lots of additional LaTeX-commands, so the cleaning provided in parseResult will not take you that far. While the idea of using .bst is excellent, in this case I think it is still better to define reference style through the other definition files.

(I've been thinking about generating previews using .bst, but cleaning up the .bbl is a mess in the general, or at least the IEEEtran.bst, case and the same thing is bound to happen here. For previews, I think a feasible way is to generate a PNG/PDF and display it, but that won't really be of any use here.)

@oscargus
Copy link
Contributor Author

Also, there's not even commented out menu items etc or any configuration.

An option would also be to keep the .bst-stuff but get rid of the push-to-application-button (and other commented out things, there are three potential buttons which are not used). Will also simplify things a bit.

@oscargus
Copy link
Contributor Author

Seems like the final commit solves #607 if nothing else.

@koppor
Copy link
Member

koppor commented Jan 2, 2016

Should we open an issue then which reads "Add bst support for OpenOffice" referencing this PR?

Regarding the previews: I assume, you mean the preview panel? I thought, the BibtexVM can be used as is for that?

@oscargus
Copy link
Contributor Author

oscargus commented Jan 2, 2016

Yes, I think it makes sense to open an issue.

Yes, the VM can be used, but for some .bst-files (e.g. IEEEtran.bst) there will be quite a bit of non-trivial latex code to parse...

koppor added a commit that referenced this pull request Jan 5, 2016
@koppor koppor merged commit f71f128 into JabRef:master Jan 5, 2016
@oscargus oscargus deleted the cleaneroo branch January 8, 2016 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup-ops openoffice/libreoffice status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants