Add support for jumping in ordered author list by typing letters

[leitianjian]

Fixes #6146

I think I have added the support for jumping to the entry when typing letters.
Should I add some comments to the method I added?
Thanks :D

• Change in CHANGELOG.md described (if applicable)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

[calixtus]

You can also shorten this with some lambda-expression:

        list.getItems().stream().filter(item -> item.getName().toLowerCase().startsWith(target_char))
            .findFirst().ifPresent(item -> { this.scrollTo(item); this.getSelectionModel().clearAndSelect(item); });

for an example, have a look at gui/preferences/PreviewTabView.java::jumpToSearchKey

[calixtus]

Hi @leitianjian , thank you very much for your contribution.
Yet I still have a question and a suggestion for your PR.

[leitianjian]

Thanks for your suggestions. The method in jumpToSearchKey provides a very good template. I will rewrite the code and try to add test cases to test it.

[leitianjian]

Hi, I think I have done it now. I used the stream to replace the for loop you have mentioned above, but I cannot construct a test case to test the method I added. I only test manually. I set the time to 700ms because I think 1s is too long for our typing.
Thanks in advance

[calixtus]

Is this ready for review?

[calixtus]

I only test manually. I set the time to 700ms because I think 1s is too long for our typing.

That's fine, There are many scenarios some gui stuff just cannot be tested.

[leitianjian]

I only test manually. I set the time to 700ms because I think 1s is too long for our typing.

That's fine, There are many scenarios some gui stuff just cannot be tested.

Yeah, I found the sad truth finally T^T

[leitianjian]

@calixtus Thanks for your suggestions, I made a mistake when I adjust the code format and had not realized that.

[koppor]

Have some code nitpicks. The acutal implementation should be (please) checked by @tobiasdiez

[tobiasdiez]

LGTM. Thanks for your contribution!

(I didn't test if this interferes with typing in the entry editor or searchbar, but it shouldn't as the event is registered on the maintable).

[leitianjian]

LGTM. Thanks for your contribution!

(I didn't test if this interferes with typing in the entry editor or searchbar, but it shouldn't as the event is registered on the maintable).

Yeah, I tested it manually, which will not interfere with the searchbar. The target of the input is depended on the focusing window

[calixtus]

Ok, 2 approvals, @koppor s suggestions are fixed and the change is tested.
I'm going to merge this now.
@leitianjian , thank you very much for your contribution. I hope you liked working on JabRef and consider to contribute more.