Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes tests remaining from bibtexkey to citationkey rebranding #6918

Merged
merged 1 commit into from
Sep 18, 2020
Merged

Fixes tests remaining from bibtexkey to citationkey rebranding #6918

merged 1 commit into from
Sep 18, 2020

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented Sep 15, 2020 •
edited
Loading

Refs #6875
Refs JabRef/user-documentation@789b631

Quick fix for helpfile tests and preferences migrations.
No changelog, since it does not have any visual effect and is just an follow-up to @mlep s work on the user documentation.
Comments?

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@calixtus calixtus changed the title Fixes tests remaining from bibtexkey to citationkey rebranding [WIP] Fixes tests remaining from bibtexkey to citationkey rebranding Sep 15, 2020
@calixtus calixtus marked this pull request as draft September 15, 2020 22:59
@Siedlerchr
Copy link
Member

seems like you need to adjust the other preview related migration tests as well

@calixtus
Copy link
Member Author

On it, used this to test the tests... 😉

@tobiasdiez
Copy link
Member

Thanks a lot! I'm traveling right now, and don't have the chance to program, otherwise I would have a look at this myself.

@calixtus
Copy link
Member Author

calixtus commented Sep 16, 2020 •
edited
Loading

Although I think I fixed the tests on the JabRef side (documentation needs a rebranding of bibtexkeypattern.md to citationkeypattern.md too), I strongly believe that PreferenceMigrationTest::testPreviewStyle and ::upgradePreviewStyleAllowMarkupDefault do have a faulty test design. Suggestions?

@calixtus calixtus marked this pull request as ready for review September 16, 2020 21:14
@calixtus calixtus changed the title [WIP] Fixes tests remaining from bibtexkey to citationkey rebranding Fixes tests remaining from bibtexkey to citationkey rebranding Sep 16, 2020
@calixtus calixtus added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 16, 2020
tobiasdiez
tobiasdiez approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I agree the tests are somewhat suboptimal. Not sure though if its worthwhile to spend more time improving them.

@Siedlerchr Siedlerchr merged commit b9be53e into master Sep 18, 2020
@Siedlerchr Siedlerchr deleted the fix_helptests branch September 18, 2020 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez approved these changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixtus @Siedlerchr @tobiasdiez