Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing "BibTeX" when not specific to BibTeX #6983

Merged
merged 10 commits into from
Oct 6, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,18 +32,19 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
- We changed the title of the window "Manage field names and content": to have the same title as the corresponding menu item [#6895](https://github.com/JabRef/jabref/pull/6895)
- We improved the detection of "short" DOIs [6880](https://github.com/JabRef/jabref/issues/6880)
- We improved the duplicate detection when identifiers like DOI or arxiv are semantiaclly the same, but just syntactically differ (e.g. with or without http(s):// prefix). [#6707](https://github.com/JabRef/jabref/issues/6707)
- We changed in the group interface "Generate groups from keywords in a BibTeX field" by "Generate groups from keywords in the following field". [#6983](https://github.com/JabRef/jabref/issues/6983)

### Fixed

- We fixed an issue changing the icon link_variation_off that is not meaningful. [#6834][https://github.com/JabRef/jabref/issues/6834]
- We fixed an issue changing the icon link_variation_off that is not meaningful. [#6834](https://github.com/JabRef/jabref/issues/6834)
- We fixed an issue where the `.sav` file was not deleted upon exiting JabRef. [#6109](https://github.com/JabRef/jabref/issues/6109)
- We fixed a linked identifier icon inconsistency. [#6705](https://github.com/JabRef/jabref/issues/6705)
- We fixed the wrong behavior that font size changes are not reflected in dialogs. [#6039](https://github.com/JabRef/jabref/issues/6039)
- We fixed the failure to Copy citation key and link. [#5835](https://github.com/JabRef/jabref/issues/5835)
- We fixed an issue where the sort order of the entry table was reset after a restart of JabRef. [#6898](https://github.com/JabRef/jabref/pull/6898)
- We fixed an issue where no longer a warning was displayed when inserting references into LibreOffice with an invalid "ReferenceParagraphFormat". [#6907](https://github.com/JabRef/jabref/pull/60907).
- We fixed an issue where a selected field was not removed after the first click in the custom entry types dialog. [#6934](https://github.com/JabRef/jabref/issues/6934)
- We fixed an issue where a remove icon was shown for standard entry types in the custom entry types dialog. [6906](https://github.com/JabRef/jabref/issues/6906)
- We fixed an issue where a remove icon was shown for standard entry types in the custom entry types dialog. [#6906](https://github.com/JabRef/jabref/issues/6906)
- We fixed an issue where it was impossible to connect to OpenOffice/LibreOffice on Mac OSX. [#6970](https://github.com/JabRef/jabref/pull/6970)
- We fixed an issue with the python script used by browser plugins that failed to locate JabRef if not installed in its default location. [#6963](https://github.com/JabRef/jabref/pull/6963/files)

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/jabref/gui/actions/StandardActions.java
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public enum StandardActions implements Action {
OPEN_EXTERNAL_FILE(Localization.lang("Open file"), IconTheme.JabRefIcons.FILE, KeyBinding.OPEN_FILE),
OPEN_URL(Localization.lang("Open URL or DOI"), IconTheme.JabRefIcons.WWW, KeyBinding.OPEN_URL_OR_DOI),
SEARCH_SHORTSCIENCE(Localization.lang("Search ShortScience")),
MERGE_WITH_FETCHED_ENTRY(Localization.lang("Get BibTeX data from %0", "DOI/ISBN/...")),
MERGE_WITH_FETCHED_ENTRY(Localization.lang("Get bibliographic data from %0", "DOI/ISBN/...")),
ATTACH_FILE(Localization.lang("Attach file"), IconTheme.JabRefIcons.ATTACH_FILE),
PRIORITY(Localization.lang("Priority"), IconTheme.JabRefIcons.PRIORITY),
CLEAR_PRIORITY(Localization.lang("Clear priority")),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public IdentifierEditor(Field field, TaskExecutor taskExecutor, DialogService di
textArea.textProperty().bindBidirectional(viewModel.textProperty());

fetchInformationByIdentifierButton.setTooltip(
new Tooltip(Localization.lang("Get BibTeX data from %0", field.getDisplayName())));
new Tooltip(Localization.lang("Get bibliographic data from %0", field.getDisplayName())));
lookupIdentifierButton.setTooltip(
new Tooltip(Localization.lang("Look up %0", field.getDisplayName())));

Expand Down
12 changes: 6 additions & 6 deletions src/main/java/org/jabref/gui/groups/GroupDialog.fxml
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,8 @@
<TextField fx:id="keywordGroupSearchTerm"/>
</VBox>
<HBox spacing="10.0">
<CheckBox fx:id="keywordGroupCaseSensitive" text="Case sensitive"/>
<CheckBox fx:id="keywordGroupRegex" text="Regular expression"/>
<CheckBox fx:id="keywordGroupCaseSensitive" text="%Case sensitive"/>
<CheckBox fx:id="keywordGroupRegex" text="%Regular expression"/>
</HBox>
</VBox>
<VBox visible="${searchRadioButton.selected}" spacing="10.0">
Expand All @@ -117,13 +117,13 @@
<TextField fx:id="searchGroupSearchTerm"/>
</VBox>
<HBox spacing="10.0">
<CheckBox fx:id="searchGroupCaseSensitive" text="Case sensitive"/>
<CheckBox fx:id="searchGroupRegex" text="Regular expression"/>
<CheckBox fx:id="searchGroupCaseSensitive" text="%Case sensitive"/>
<CheckBox fx:id="searchGroupRegex" text="%Regular expression"/>
</HBox>
</VBox>
<VBox visible="${autoRadioButton.selected}" spacing="10.0">
<RadioButton fx:id="autoGroupKeywordsOption" toggleGroup="$autoGroupOptions"
text="Generate groups from keywords in a BibTeX field"/>
text="%Generate groups from keywords in the following field"/>
<VBox spacing="10.0">
<padding>
<Insets left="20.0"/>
Expand Down Expand Up @@ -154,7 +154,7 @@
</HBox>
</VBox>
<RadioButton fx:id="autoGroupPersonsOption" toggleGroup="$autoGroupOptions"
text="Generate groups for author last names"/>
text="%Generate groups for author last names"/>
<VBox>
<padding>
<Insets left="20.0"/>
Expand Down
5 changes: 4 additions & 1 deletion src/main/resources/l10n/JabRef_en.properties
Original file line number Diff line number Diff line change
Expand Up @@ -1591,7 +1591,7 @@ remove\ entry\ %0=remove entry %0
remove\ string\ %0=remove string %0
undefined=undefined
Cannot\ get\ info\ based\ on\ given\ %0\:\ %1=Cannot get info based on given %0: %1
Get\ BibTeX\ data\ from\ %0=Get BibTeX data from %0
Get\ bibliographic\ data\ from\ %0=Get bibliographic data from %0
No\ %0\ found=No %0 found
Entry\ from\ %0=Entry from %0
Merge\ entry\ with\ %0\ information=Merge entry with %0 information
Expand Down Expand Up @@ -2273,3 +2273,6 @@ Check\ Proxy\ Setting=Check Proxy Setting
Check\ connection=Check connection
Connection\ failed\!=Connection failed\!
Connection\ successful\!=Connection successful\!
Generate\ groups\ from\ keywords\ in\ the\ following\ field=Generate groups from keywords in the following field
Generate\ groups\ for\ author\ last\ names=Generate groups for author last names
Regular\ expression=Regular expression