Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Shared Database Tests #7040

Merged
merged 7 commits into from
Nov 3, 2020
Merged

Fix Shared Database Tests #7040

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
18805b1
Fix Shared Database Tests
Siedlerchr Oct 25, 2020
7b704e2
Use length directly foir comparision
Siedlerchr Oct 26, 2020
0c4d410
Merge remote-tracking branch 'upstream/master' into sharedbtest
Siedlerchr Oct 28, 2020
1b15ed5
Merge remote-tracking branch 'upstream/master' into sharedbtest
Siedlerchr Nov 3, 2020
83fc123
Merge remote-tracking branch 'upstream/master' into sharedbtest
Siedlerchr Nov 3, 2020
27674f3
upgrade postgres to 13
Siedlerchr Nov 3, 2020
bac9ff9
revert unrelated change
Siedlerchr Nov 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/main/java/org/jabref/model/entry/event/FieldChangedEvent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,12 @@ public FieldChangedEvent(FieldChange fieldChange) {
private int computeDelta(String oldValue, String newValue) {
if (oldValue == newValue) {
return 0;
} else if (oldValue == null && newValue != null) {
} else if ((oldValue == null) && (newValue != null)) {
return newValue.length();
} else if (newValue == null && oldValue != null) {
} else if ((newValue == null) && (oldValue != null)) {
return oldValue.length();
} else if ((Math.abs(newValue.length() - oldValue.length()) == 0) && !oldValue.equals(newValue)) {
Siedlerchr marked this conversation as resolved.
Show resolved Hide resolved
return newValue.length();
Siedlerchr marked this conversation as resolved.
Show resolved Hide resolved
} else {
return Math.abs(newValue.length() - oldValue.length());
}
Expand Down