-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added eye candy in entry editor context menus #7268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tobiasdiez , I'm currently refactoring the context menu for the field editors. It's still work in progress, but I encountered some design choices of yours I don't understand. Can you help me out here?
src/main/java/org/jabref/gui/fieldeditors/contextmenu/EditorContextAction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jabref/gui/fieldeditors/contextmenu/EditorContextAction.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on mac + codewise also lgtm
This PR adds some eye candy in the entry editor editors context menu.
Sadly, the TextField in the FXChipView is not accessible, so this one lacks eye candy.
Still WIP, I'll see if I can fix some misplaced other menu entries.
Refs #5352