Integrated CustomizeExternalFileTypesDialog into Preferences #8341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might check if this als fixes #5902 |
|
Probably not, as i only integrated the dialog in the preferences dialog, but i did not change anything on the table. |
|
But this rather seems to be a javafx bug. |
Siedlerchr
approved these changes
Dec 19, 2021
|
Merge after 5.4 release due to l10n change |
calixtus
added
preferences
status: ready-for-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of opening the dialog with a button inside the External programs tab in the preferences nested inside the Push to applications preferences, this dialog has now it's own tab in the preferences.
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)